👷 setup GitHub CI #140
Merged
👷 setup GitHub CI #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpetetot
force-pushed
the
feature/github-actions
branch
4 times, most recently
from
9730231
to
c94be28
Compare
bpetetot
force-pushed
the
feature/github-actions
branch
from
c94be28
to
1a1fa7e
Compare
frinyvonnick
approved these changes
Nov 13, 2019
kefranabg
reviewed
Nov 13, 2019
| @@ -0,0 +1,30 @@ | |||
| name: Test and lint | |||
|
|
|||
| on: [push] | |||
There was a problem hiding this comment.
not sure it will be triggered for external contributors 😞 I think you'll need to add the pull_request hook.
There was a problem hiding this comment.
Indeed, good catch 👍 I'm going to change it with:
on: [push, pull_request]
There was a problem hiding this comment.
I just noticed that when it's your pull request, the process will run twice 😅 Maybe just using pull_request would work?
There was a problem hiding this comment.
or maybe something like that:
on:
pull_request:
push:
branches:
- master
I think it will trigger on all pull_request or when someone push on master.
There was a problem hiding this comment.
I confirm this one is working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #139