Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't generate CHANGELOG because "Error: is not a valid semver version." #136

Closed
frinyvonnick opened this issue Nov 12, 2019 · 4 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@frinyvonnick
Copy link
Owner

frinyvonnick commented Nov 12, 2019

I failed to generate a changelog on https://github.com/EmrysMyrddin/cuillere because of the following Error:

gitmoji-changelog
▶  start     gitmoji-changelog v2.0.0
ℹ  info      init ./CHANGELOG.md
ℹ  info      use preset node
✖  error     Error:  is not a valid semver version.

The list of tags seems great:

v0.1.0
v0.2.0
v0.3.0
v0.4.0
(END)

This is an initialization use case

@frinyvonnick frinyvonnick added the bug Something isn't working label Nov 12, 2019
@frinyvonnick frinyvonnick added this to the Roadmap milestone Nov 12, 2019
@frinyvonnick
Copy link
Owner Author

This Error is linked to #138

@bpetetot
Copy link
Collaborator

It doesn't work because cuillere is a monorepo using yarn workspaces.
So in the root package.json there is no version defined. Versions are defined in each packages.

I have some interrogations:

  • Do we need to improve node preset in order to manage monorepo without root version ?
  • For monorepo, do we need to be able to manage one changelog and/or version by package ?
  • Do we need to create a yarn or yarn-workspace preset ?
  • And with lerna, do we need a dedicated preset, to be able to manage one changelog and/or version by package ?

@bpetetot
Copy link
Collaborator

@frinyvonnick I think, in that case we could think to dedicated presets for monorepo.

@frinyvonnick
Copy link
Owner Author

Sure, we could open an issue about monorepos to debate on these questions 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants