Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving default components like position, rotation and transform to different namespace #14

Open
erdemserhatergen opened this issue Sep 7, 2024 · 5 comments

Comments

@erdemserhatergen
Copy link

Having these components default from friflo results clash with rendering frameworks like fna and mono. I'm not a C# expert so couldn't find a good way to exclude those from my includes.

Do you think it would be good idea to move them to different namespace for library?

@friflo
Copy link
Owner

friflo commented Nov 1, 2024

Doing this will break compatibility.
So I don't want to do this at the moment.

@friflo
Copy link
Owner

friflo commented Nov 1, 2024

Similar to #26

@friflo
Copy link
Owner

friflo commented Nov 1, 2024

In case changing the mentioned types I would move them to namespace Friflo.ECS.Math.
I let this topic open for better naming suggestions.

@popcron
Copy link

popcron commented Nov 24, 2024

i agree with @erdemserhatergen and #26, but its already been put in place so yes technically it will break compatibility. but these types didnt need to be written as included in the first place! people can implement those themselves. maybe not for EntityName so easily as i think that should be a feature native to the lib without a component in use, but definitely for pos/rot/matrix components.

as for the namespace if theyre to be moved, Friflo.ECS.Components or Friflo.ECS.BuiltIn sound more fitting than Math.

@erdemserhatergen
Copy link
Author

In case changing the mentioned types I would move them to namespace Friflo.ECS.Math. I let this topic open for better naming suggestions.

Thanks for the information and still thinking about moving them to other namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants