PHP 8.1/8.2 Compatibility #12011

MrPetovan · 2022-10-17T19:09:57Z

If you're running PHP 8.1 and higher, please post here your PHP Deprecated notices.

nupplaphil · 2022-10-17T19:51:54Z

We should consider a "maximum" php version, because the deprecation notice is impossible to fix with our current base-version. The type "mixed" isn't supported yet ;-)

MrPetovan · 2022-10-17T20:00:27Z

We can use the special attribute #[\ReturnTypeWillChange] as well. It resolves to a single line comment in PHP <8.0.

MrPetovan · 2022-10-20T13:00:43Z

Yes, please share all the Warnings (including these) and Errors from your log in #11993 and #11992 respectively.

utzer · 2022-11-19T20:38:19Z

@MrPetovan ok, I will do so from now on.

One question, do you have a idea why avatars are often not shown? I have this since the update and it is annoying. Another problem is I can not follow any new users anymore, it will instead follow the .rss of the account, which is also really annoying.

MrPetovan · 2022-11-19T20:59:44Z

Which update? The last stable version isn't so stable, the develop branch has received several patches for concerning issues.

utzer · 2022-11-19T21:08:44Z

Which update? The last stable version isn't so stable, the develop branch has received several patches for concerning issues.

I was going to ask that as well, so the current dev is better than the last stable I guess, I will switch if you say so.

Also where should I share these Deprecated errors then? In the Warnings issue?

MrPetovan · 2022-11-19T21:34:58Z

Deprecation errors go here because they are related to PHP 8, non-Deprecation errors go over there.

MrPetovan · 2022-11-19T22:12:41Z

Thank you, this is very helpful!

MrPetovan · 2022-11-19T23:36:45Z

/authorize_interaction is a Mastodon route, please open a separate issue for it, as it isn't a PHP 8 compatibility issue nor a PHP Warning.

utzer · 2022-11-20T00:13:59Z

/authorize_interaction is a Mastodon route, please open a separate issue for it, as it isn't a PHP 8 compatibility issue nor a PHP Warning.

Done.
#12220

MrPetovan · 2022-11-20T17:55:42Z

So, it looks like you submitted several that should have been fixed in #12221 and friendica/friendica-addons#1315, please make sure you wipe out your log so that you don't submit duplicates.

The second list belongs here but isn't very useful without the earlier lines of the message, see #12011 (comment) for an example of complete output.

utzer · 2022-11-20T18:32:10Z

So, it looks like you submitted several that should have been fixed in

ah sorry, my bad. I will update above after.

The second list belongs here but isn't very useful without the earlier lines of the message, see #12011 (comment) for an example of complete output.

Hmm for that other thing I am confused, I think the sed cuts off the lines, because it seems this "attribute should be used to temporarily suppress the notice " is always part of a "Deprecated" line, right?

MrPetovan · 2022-11-20T18:58:01Z

Yes but it’s leaving out several details useful to fix them, I was guessing the message was multi-line on your system.

utzer · 2022-11-20T19:58:54Z

Yes but it’s leaving out several details useful to fix them, I was guessing the message was multi-line on your system.

no, the sed breaks the lines I think, asked on Friendica for some help to improve the sed command.

…ib2_compat - Add missing use statement in SecureTestEmail - Hopefully address friendica/friendica#12011 (comment)

- Address part of friendica/friendica#12011 (comment)

MrPetovan · 2022-11-23T18:39:50Z

For the follow issue, can you please check if it's the same problem with the system account as in this issue: #12185

MrPetovan · 2023-04-26T19:10:34Z

We should be doing a hotfix release soon, so it's unlikely this deprecation notice will be addressed in the upcoming release.

utzer · 2023-05-03T13:31:38Z

Latest stable running.

Server 1:

21132502  PHP Deprecated:  Creation of dynamic property PDOStatement::$table is deprecated in /var/www/src/Database/Database.php on line 1514
  65682  PHP Deprecated:  Implicit conversion from float 41.024992192379 to int loses precision in /var/www/addon/smileybutton/smileybutton.php on line 93
     14  PHP Deprecated:  mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead in /var/www/addon/showmore/showmore.php on line 128
  13978  PHP Deprecated:  mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead in /var/www/src/Content/Text/HTML.php on line 179
   1657  PHP Deprecated:  mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead in /var/www/src/Content/Text/HTML.php on line 579
     31  PHP Deprecated:  mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead in /var/www/src/Util/ParseUrl.php on line 311

That 21132502 times are just for today, so the error in that line occurred 21132502 within the last 15h30m.

PHP: 8.2.5

It is taking a toll on my system now, often pages don't load.

Server 2:

      1  PHP Deprecated:  Creation of dynamic property Friendica\Module\Calendar\Event\Get::$app is deprecated in /var/www/src/Module/Calendar/Event/Get.php on line 54
     11  PHP Deprecated:  Creation of dynamic property Friendica\Object\Api\Mastodon\ListEntity::$replies_policy is deprecated in /var/www/src/Object/Api/Mastodon/ListEntity.php on line 49
    114  PHP Deprecated:  Creation of dynamic property Friendica\Object\Api\Mastodon\Preferences::$posting:default:language is deprecated in /var/www/src/Object/Api/Mastodon/Preferences.php on line 58
    114  PHP Deprecated:  Creation of dynamic property Friendica\Object\Api\Mastodon\Preferences::$posting:default:sensitive is deprecated in /var/www/src/Object/Api/Mastodon/Preferences.php on line 57
    114  PHP Deprecated:  Creation of dynamic property Friendica\Object\Api\Mastodon\Preferences::$posting:default:visibility is deprecated in /var/www/src/Object/Api/Mastodon/Preferences.php on line 56
    114  PHP Deprecated:  Creation of dynamic property Friendica\Object\Api\Mastodon\Preferences::$reading:expand:media is deprecated in /var/www/src/Object/Api/Mastodon/Preferences.php on line 59
    114  PHP Deprecated:  Creation of dynamic property Friendica\Object\Api\Mastodon\Preferences::$reading:expand:spoilers is deprecated in /var/www/src/Object/Api/Mastodon/Preferences.php on line 60
    307  PHP Deprecated:  mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead in /var/www/addon/showmore/showmore.php on line 128
     24  PHP Deprecated:  mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead in /var/www/src/App/Page.php on line 522
 120267  PHP Deprecated:  mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead in /var/www/src/Content/Text/HTML.php on line 179
   9344  PHP Deprecated:  mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead in /var/www/src/Content/Text/HTML.php on line 579
     13  PHP Deprecated:  mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead in /var/www/src/Util/ParseUrl.php on line 311
     16  PHP Deprecated:  strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/addon/openstreetmap/openstreetmap.php on line 59
      4  PHP Deprecated:  strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/src/Model/Item.php on line 3070

PHP: 8.2.5

Not sure why server 2 looks different.

MrPetovan · 2023-05-03T14:55:29Z

That's a new one for sure.

- Address part of friendica#12011 (comment)

- Address friendica#12011 (comment)

annando · 2023-11-24T13:43:30Z

Are there any compatibility issues any more? I'm running with 8.2 on my machines and I haven't got any issues.

utzer · 2023-11-26T14:03:10Z

Are there any compatibility issues any more? I'm running with 8.2 on my machines and I haven't got any issues.

only these:

  17549  PHP Deprecated:  ctype_space(): Argument of type int will be interpreted as string in the future in /var/www/src/Content/Smilies.php on line 230
  25632  PHP Deprecated:  Implicit conversion from float 41.024992192379 to int loses precision in /var/www/addon/smileybutton/smileybutton.php on line 93
     40  PHP Deprecated:  mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead in /var/www/addon/showmore/showmore.php on line 128
  15829  PHP Deprecated:  mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead in /var/www/src/Content/Text/HTML.php on line 178
   5883  PHP Deprecated:  mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead in /var/www/src/Content/Text/HTML.php on line 581
      9  PHP Deprecated:  mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead in /var/www/src/Util/ParseUrl.php on line 311
     30  PHP Deprecated:  mb_strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/src/Protocol/ActivityPub/Processor.php on line 1731
    338  PHP Deprecated:  Optional parameter $rules declared before required parameter $configuration is implicitly treated as a required parameter in /var/www/src/Object/Api/Mastodon/Instance.php on line 87

leading number is how often the message is found in the logs today.

PHP: 8.2.12

MrPetovan · 2023-11-26T14:22:18Z

We still don't have a good solution for mb_convert_encoding but I can look into the others.

25632 PHP Deprecated: Implicit conversion from float 41.024992192379 to int loses precision in /var/www/addon/smileybutton/smileybutton.php on line 93

This was fixed in October 20th in https://git.friendi.ca/friendica/friendica-addons/pulls/1431, please pull the 2023.09-rc branch from the addon repo.

…rmForEachWordMatch - Address part of friendica#12011 (comment)

- Address part of friendica#12011 (comment)

- Address friendica/friendica#12011 (comment)

Mannshoch · 2023-12-28T09:13:16Z

I'm on 2023.12
My hoster updated to 8.2
Now I get this error:

Deprecated: Creation of dynamic property GuzzleHttp\Psr7\LazyOpenStream::$stream is deprecated in /vendor/guzzlehttp/psr7/src/StreamDecoratorTrait.php on line 33

Warning: Cannot modify header information - headers already sent by (output started at /vendor/guzzlehttp/psr7/src/StreamDecoratorTrait.php:33) in /src/App/Page.php on line 513

Warning: Cannot modify header information - headers already sent by (output started at /vendor/guzzlehttp/psr7/src/StreamDecoratorTrait.php:33) in /src/App/Page.php on line 514

Warning: Cannot modify header information - headers already sent by (output started at /vendor/guzzlehttp/psr7/src/StreamDecoratorTrait.php:33) in /src/App/Page.php on line 521

Warning: Cannot modify header information - headers already sent by (output started at /vendor/guzzlehttp/psr7/src/StreamDecoratorTrait.php:33) in /src/App/Page.php on line 522

Warning: Cannot modify header information - headers already sent by (output started at /vendor/guzzlehttp/psr7/src/StreamDecoratorTrait.php:33) in /src/App/Page.php on line 523

Warning: Cannot modify header information - headers already sent by (output started at /vendor/guzzlehttp/psr7/src/StreamDecoratorTrait.php:33) in /src/App/Page.php on line 524

Warning: Cannot modify header information - headers already sent by (output started at /vendor/guzzlehttp/psr7/src/StreamDecoratorTrait.php:33) in /src/Core/System.php on line 291

Warning: Cannot modify header information - headers already sent by (output started at /vendor/guzzlehttp/psr7/src/StreamDecoratorTrait.php:33) in /src/Core/System.php on line 307

My hoster allow to to request for lower php versions. Do I have to do it?

[EDIT]
I found in the logs an error on updating to 2023.12 may that's the cause?:

bin/composer.phar install --no-dev

The "plesk/composer-command-info" plugin was skipped because it requires a Plugin API version ("^2.0") that does not match your Composer installation ("1.1.0"). You may need to run composer update with the "--no-plugins" option.
You are using Composer 1 which is deprecated. You should upgrade to Composer 2, see https://blog.packagist.com/deprecating-composer-1-support/
Loading composer repositories with package information
Installing dependencies from lock file
Nothing to install or update
Pac...

MrPetovan · 2023-12-28T17:03:56Z

Thank you for the report, I’d recommend you disable the HTML display of PHP error messages. Not sure how you can change individual php.ini configuration keys in your hoster setup but you’re looking to set the display_errors key to 0.

And the Composer deprecation warning is irrelevant (for now).

Mannshoch · 2023-12-28T23:02:05Z

Also since Update on my Android in the app fedilab posting not work anymore.

MrPetovan · 2023-12-28T23:34:17Z

This is unlikely to be related to a PHP 8 deprecation issue.

Mannshoch · 2023-12-29T07:52:59Z

Also since Update on my Android in the app fedilab posting not work anymore.

@MrPetovan
Your proposal to deactivate display errors solved also the issue on the android app.

MrPetovan · 2023-12-29T15:02:05Z

So it was related after all!

This comment was marked as resolved.

Sign in to view

MrPetovan added Bug PHP 8.1 labels Oct 17, 2022

MrPetovan added this to the 2022.12 milestone Oct 17, 2022

MrPetovan mentioned this issue Oct 17, 2022

[2022.12] PHP Notices #11994

Closed

This comment was marked as off-topic.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This was referenced Nov 20, 2022

Fix various PHP 8 deprecations #12221

Merged

[various] Fix PHP 8 deprecation warnings friendica/friendica-addons#1315

Merged

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

MrPetovan added a commit to MrPetovan/friendica-addons that referenced this issue Nov 23, 2022

[securemail] Update phpseclib dependency to version 3 through phpsecl…

5b58da2

…ib2_compat - Add missing use statement in SecureTestEmail - Hopefully address friendica/friendica#12011 (comment)

MrPetovan added a commit to MrPetovan/friendica-addons that referenced this issue Nov 23, 2022

[startpage] Remove deprecated call to strlen

bf78429

- Address part of friendica/friendica#12011 (comment)

This comment was marked as resolved.

Sign in to view

MrPetovan added a commit to MrPetovan/friendica that referenced this issue May 20, 2023

Move current table property from PDOStatement to Database class

ce2abcd

- Address part of friendica#12011 (comment)

MrPetovan mentioned this issue May 20, 2023

Move current table property from PDOStatement to Database class #13146

Merged

tobiasd modified the milestones: 2023.05, 2023.09 May 23, 2023

MrPetovan mentioned this issue May 24, 2023

Deprecation warning in page #13159

Closed

MrPetovan added a commit to MrPetovan/friendica that referenced this issue May 24, 2023

Remove direct call to is_string() from templates

ced6680

- Address friendica#12011 (comment)

MrPetovan mentioned this issue May 24, 2023

Remove direct call to is_string() from templates #13160

Merged

MrPetovan closed this as completed Nov 25, 2023

MrPetovan added a commit to MrPetovan/friendica that referenced this issue Nov 26, 2023

Pass actual string character to ctype_space in Content\Smilies::perfo…

332ab66

…rmForEachWordMatch - Address part of friendica#12011 (comment)

MrPetovan added a commit to MrPetovan/friendica that referenced this issue Nov 26, 2023

Skip empty name tags in ActivityPub\Processor::acceptIncomingMessage

838c73c

- Address part of friendica#12011 (comment)

MrPetovan added a commit to MrPetovan/friendica that referenced this issue Nov 26, 2023

Remove DI dependency in Object\Api\Mastodon\Instance

ebb26a1

- Address part of friendica#12011 (comment)

MrPetovan added a commit to MrPetovan/friendica that referenced this issue Nov 26, 2023

Remove DI dependency in Object\Api\Mastodon\Instance

fb19176

- Address part of friendica#12011 (comment)

MrPetovan mentioned this issue Nov 26, 2023

Address several deprecation notices #13672

Merged

MrPetovan reopened this Dec 13, 2023

MrPetovan mentioned this issue Dec 13, 2023

Error with language detection when composing new message #13715

Open

This comment was marked as resolved.

Sign in to view

friendica pushed a commit to friendica/friendica-addons that referenced this issue Dec 20, 2023

[s3_storage] Bump version of akeeba/s3 to version 2.3.1

3e74af9

- Address friendica/friendica#12011 (comment)

PHP 8.1/8.2 Compatibility #12011

PHP 8.1/8.2 Compatibility #12011

Comments

MrPetovan commented Oct 17, 2022 • edited Loading

This comment was marked as resolved.

nupplaphil commented Oct 17, 2022

MrPetovan commented Oct 17, 2022 • edited Loading

This comment was marked as off-topic.

MrPetovan commented Oct 20, 2022

utzer commented Nov 19, 2022

MrPetovan commented Nov 19, 2022

utzer commented Nov 19, 2022 • edited Loading

MrPetovan commented Nov 19, 2022

This comment was marked as resolved.

MrPetovan commented Nov 19, 2022

This comment was marked as off-topic.

MrPetovan commented Nov 19, 2022

utzer commented Nov 20, 2022

This comment was marked as outdated.

MrPetovan commented Nov 20, 2022 • edited Loading

utzer commented Nov 20, 2022

MrPetovan commented Nov 20, 2022 • edited Loading

utzer commented Nov 20, 2022

This comment was marked as outdated.

This comment was marked as resolved.

MrPetovan commented Nov 23, 2022

This comment was marked as resolved.

MrPetovan commented Apr 26, 2023

utzer commented May 3, 2023

MrPetovan commented May 3, 2023

annando commented Nov 24, 2023

utzer commented Nov 26, 2023 • edited Loading

MrPetovan commented Nov 26, 2023 • edited Loading

This comment was marked as resolved.

Mannshoch commented Dec 28, 2023 • edited Loading

MrPetovan commented Dec 28, 2023

Mannshoch commented Dec 28, 2023

MrPetovan commented Dec 28, 2023

Mannshoch commented Dec 29, 2023

MrPetovan commented Dec 29, 2023

MrPetovan commented Oct 17, 2022 •

edited

Loading

MrPetovan commented Oct 17, 2022 •

edited

Loading

utzer commented Nov 19, 2022 •

edited

Loading

MrPetovan commented Nov 20, 2022 •

edited

Loading

MrPetovan commented Nov 20, 2022 •

edited

Loading

utzer commented Nov 26, 2023 •

edited

Loading

MrPetovan commented Nov 26, 2023 •

edited

Loading

Mannshoch commented Dec 28, 2023 •

edited

Loading