Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Invalid CSV file intermittently being considered valid #295

Open
vitorbaptista opened this issue Feb 21, 2018 · 0 comments
Open

Invalid CSV file intermittently being considered valid #295

vitorbaptista opened this issue Feb 21, 2018 · 0 comments
Labels

Comments

@vitorbaptista
Copy link
Contributor

If we keep enabling/disabling "Ignore blank rows" and/or "Ignore duplicate rows", some times an invalid CSV file is identified as valid. Seems like there is a race condition somewhere.

How to reproduce

  1. Go to https://try.goodtables.io/?source=https%3A%2F%2Fraw.githubusercontent.com%2Ffrictionlessdata%2Fgoodtables-py%2Fbc6470a970aacf65f20a3ddb7f71eb05a2a31c70%2Fdata%2Finvalid-on-structure.csv
  2. Click on "Validate"
  • You should see some validation errors
  1. Enable "Ignore blank rows" and/or "Ignore duplicate rows" and validate again
  2. If there's still some errors, go back to the previous step, changing the ignore options

Here's an example of a job that displayed the errors correctly:

https://try.goodtables.io/?source=https%3A%2F%2Fraw.githubusercontent.com%2Ffrictionlessdata%2Fgoodtables-py%2Fbc6470a970aacf65f20a3ddb7f71eb05a2a31c70%2Fdata%2Finvalid-on-structure.csv&apiJobId=45cedf3e-1706-11e8-9203-0242ac110008

And here another one that incorrectly tell that the data is valid:

https://try.goodtables.io/?source=https%3A%2F%2Fraw.githubusercontent.com%2Ffrictionlessdata%2Fgoodtables-py%2Fbc6470a970aacf65f20a3ddb7f71eb05a2a31c70%2Fdata%2Finvalid-on-structure.csv&apiJobId=be4a592c-1706-11e8-b944-0242ac110008

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant