Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Add webhook support to API sources #227

Open
3 tasks
amercader opened this issue May 26, 2017 · 1 comment
Open
3 tasks

Add webhook support to API sources #227

amercader opened this issue May 26, 2017 · 1 comment

Comments

@amercader
Copy link
Member

amercader commented May 26, 2017

While third-party integrations could periodically poll /api/source/xxx/job/yyy (or /api/job/yyyy, whatever we go for on #166) to check if a job was finished, we can make their* life easier if we add support for a webhook that gets called when a job is finished.

This should be really easy to implement for us, as we already have signals that get called whenever a job if finished. At that point we should check if the source has a callback option and if so we POST the job object to it

Tasks:

  • Accept a callback param on the source creation/update endpoint, and validate that it is a URL
  • Signal called at the end of each job, checks if there is a callback, and POSTs a JSON reprensentation of the job (including report)
  • Add support for signing the payloads (callback_secret param)

*by their I also mean ours, as we'll be implementing some of them

@pwalsh
Copy link
Member

pwalsh commented May 26, 2017

Excellent!

@amercader amercader added this to the Gamma milestone May 26, 2017
@roll roll added feature and removed [2d] labels May 20, 2019
@roll roll removed this from the Gamma milestone Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants