Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example scripts to tests #39

Open
s-celles opened this issue Oct 4, 2018 · 2 comments
Open

Add example scripts to tests #39

s-celles opened this issue Oct 4, 2018 · 2 comments
Labels
contribute enhancement

Comments

@s-celles
Copy link
Contributor

s-celles commented Oct 4, 2018

Running https://github.com/frictionlessdata/TableSchema.jl/tree/master/examples from unit tests could ensure that examples are running correctly
@loleg loleg changed the title add examples to tests Add example scripts to tests Oct 7, 2018
@loleg
Copy link
Collaborator

loleg commented Oct 7, 2018

The examples code is just a copy of the test code. I don't think we need both, and instead move the example scripts to the docs.

@roll is it a requirement to have an examples folder like in datapackage-py, or just a convention that we could drop?

@roll
Copy link
Member

roll commented Oct 8, 2018 •
edited
Loading

@loleg
Yes, it's just a usual folder structure for the libs but not a requirement

@roll roll added the contribute label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribute enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@loleg @s-celles @roll