Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for device state (Enabled = true/false) #25

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

frgnca
Copy link
Owner

@frgnca frgnca commented Aug 12, 2018

Should be able to support
Get-AudioDevice -List -ShowDisabled

Get-AudioDevice -ID <string> (ID of a disabled device)
Get-AudioDevice -Index <int> (Index of a disabled device)

Should also add new attribut Enabled (bool) to AudioDevice object

frgnca added 4 commits August 11, 2018 12:16
* add ShowDisabled parameter process

* add ShowDisabled process to List parameter

* change var name
change comment
@frgnca
Copy link
Owner Author

frgnca commented Jan 23, 2022

I'm considering scraping the -ShowDisabled feature in favor of showing all devices by default (enabled or not) as it is the default behavior in the classic Sound control panel.

One thing to note is that assigning an Index to each disabled devices newly showing might change the Index of potentially already used devices. For this reason, I'm thinking of waiting for a future v4.0 release to add that feature so that the change in behavior comes only with a major release.

@frgnca frgnca marked this pull request as draft January 23, 2022 15:33
@frgnca frgnca changed the base branch from dev_v3.0.1 to dev_v3.1 January 23, 2022 18:09
@frgnca frgnca changed the title add -ShowDisabled feature Enabled/Disabled Jan 23, 2022
@frgnca frgnca changed the base branch from dev_v3.1 to master January 23, 2022 23:37
@frgnca frgnca changed the title Enabled/Disabled add support for device state (Enabled = true/false) Jan 24, 2022
@frgnca frgnca linked an issue Jan 24, 2022 that may be closed by this pull request
@frgnca frgnca linked an issue Jul 1, 2022 that may be closed by this pull request
@God-damnit-all
Copy link

I'm considering scraping the -ShowDisabled feature in favor of showing all devices by default (enabled or not) as it is the default behavior in the classic Sound control panel.

One thing to note is that assigning an Index to each disabled devices newly showing might change the Index of potentially already used devices. For this reason, I'm thinking of waiting for a future v4.0 release to add that feature so that the change in behavior comes only with a major release.

As someone who has virtual audio devices as well as a sound card, capture card, and extraneous sound devices from the motherboard's integrated sound, that'd be rather messy.

I think the most ideal behavior would be to have disabled devices hidden cosmetically and indexing the audio devices the same regardless. -ShowDisabled would just add the already indexed disabled devices to the command output instead of omitting them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change status of non-default audio device Feature request - Control disabled devices
2 participants