Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple settings logic #38

Open
frextrite opened this issue Aug 17, 2019 · 0 comments
Open

Decouple settings logic #38

frextrite opened this issue Aug 17, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@frextrite
Copy link
Owner

Currently, we have 3 classes for working with settings

  • ProjectSettings (a ProjectComponent) handles the runtime settings (if any)
  • CodeAnalysisSettingsPage contains logic for settings page
  • CodeAnalysisSettingsPersistent to persist the settings to the fs

Changes done in settings page, need to modify both the other classes.

Possible solution:

  • Make CodeAnalysisSettingsPage an applicationConfigurable and CodeAnalysisSettingsPersistent as an ApplicationService
  • the main action to run coala, would first call internal method to update ProjectSettings which would in-turn load all the settings from the persistent class and,
  • all the other classes (in a particular project) would communicate directly with ProjectSettings class.
@frextrite frextrite added the enhancement New feature or request label Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant