-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove calls to unwrap #7
Comments
I started working on this (here's the branch), but a little blocked on moving forward because the |
I missed your comment here and implemented it already. I implemented a new Error type for |
reopening – we still have a few unwrap calls we need to remove |
These two unwraps WILL panic on macOS if set_application should be run within a |
(From my comment on reddit and as a reminder for myself)
You might want to change the notify method to return a
Result<(), SomeErrorType>
and don't callunwrap()
in your code. It is considered bad practice for a library to panic.The text was updated successfully, but these errors were encountered: