-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 0.9.9 release #172
base: master
Are you sure you want to change the base?
Conversation
a8ac797
to
ead9990
Compare
@igneus You've worked on the tests before... Do you know why they are failing? I see an inconsistent use of utf-8 vs UTF-8. I thought that UTF-8 is more correct? I understand that it's the I don't know MusicXML at all. |
@fedelibre In fact I found most tests failing and in #170 I fixed all which were "just broken tests" (i.e. the code under test worked, just the expected output was out of sync with developments of the codebase). I intentionally left two failing tests, because the results were obviously incorrect. I'll check current state of the affairs later today. |
... but yes, in one sense I am the one who caused the tests failing: I made them run automatically and publicly. Prior to #170 they were only run manually (if anyone cared to run them), now they run on each push and each pull request. |
@fedelibre Would it be acceptable to mark the two failing tests as known failures (I will provide code for that), so the test suite will pass, and open an issue to keep track of this (or reopen #153)? I will be happy to look more into this, but I definitely won't make the December 13th deadline.
|
Yes, of course.Please go ahead and feel free to add your commits in this branch. Thanks
|
I've set 13th of December as release date, as we might need some time to review again the LilyPond syntax and other stuff.