Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the nox jobs in one job that can be used for branch protection #131

Closed
llucax opened this issue Sep 11, 2023 · 1 comment
Closed
Labels
part:ci Affects the GitHub workflow and other parts for running CI part:cookiecutter Affects the generation of projects using cookiecutter type:enhancement New feature or enhancement visitble to users
Milestone

Comments

@llucax
Copy link
Contributor

llucax commented Sep 11, 2023

What's needed?

We need to avoid having to update branch protection rules each time a new matrix item is added or removed from the nox job.

Proposed solution

Same as the cross-arch test jobs in the SDK:

https://github.com/frequenz-floss/frequenz-sdk-python/blob/d34aea674ee10363a3b99bb01d7b2d2b67d94a1d/.github/workflows/ci.yaml#L175-L188

If we make one nox job that depends on all the matrix jobs, then we can use that for branch protection so we don't need to update the protection rules each time the matrix is changed.

Use cases

No response

Alternatives and workarounds

No response

Additional context

SDK PR:

@llucax llucax added type:enhancement New feature or enhancement visitble to users part:cookiecutter Affects the generation of projects using cookiecutter part:ci Affects the GitHub workflow and other parts for running CI labels Sep 11, 2023
@llucax llucax added this to the v0.9.0 milestone Sep 11, 2023
@llucax llucax modified the milestones: v0.9.0, v0.11.0 Nov 1, 2023
@llucax llucax modified the milestones: v0.11.0, v0.12.0 Dec 18, 2023
@llucax
Copy link
Contributor Author

llucax commented Jul 17, 2024

This was done already.

@llucax llucax closed this as completed Jul 17, 2024
@llucax llucax modified the milestones: v0.12.0, v0.7.0 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:ci Affects the GitHub workflow and other parts for running CI part:cookiecutter Affects the generation of projects using cookiecutter type:enhancement New feature or enhancement visitble to users
Projects
None yet
Development

No branches or pull requests

1 participant