Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parachain node docker image for Rococo and Mainnet #417

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

demisx
Copy link
Collaborator

@demisx demisx commented Sep 12, 2022

Goal

The goal of this PR is create a docker image for running Frequency parachain full node.

Part of #372

@demisx demisx self-assigned this Sep 12, 2022
@demisx demisx requested a review from wilwade September 12, 2022 19:10
@demisx demisx force-pushed the 372-better-docker-files branch 3 times, most recently from 3686972 to d525ea2 Compare September 12, 2022 19:18
@demisx demisx marked this pull request as ready for review September 12, 2022 19:19
@demisx
Copy link
Collaborator Author

demisx commented Sep 12, 2022

@wilwade The first PR for rococo-node image publishing to the new frequencychain Docker Hub is ready for initial review. This is a stripped down image that I am asking to be reviewed to make sure I am on the right path here.

The rococo-node image can be tested this way:

  1. Shut down any running Frequency local node, if running. The instant seal node is publishing to 9944, 9933 and 30333 , so these ports need to be available prior to running docker.
  2. Start local chain in instant seal mode with this new docker image:
    docker run --rm -p 9944:9944 -p 9933:9944 -p 30333:30333 frequencychain/rococo-node
  3. Once the local chain is running, verify you can explore it with https://polkadot.js.org/apps/?rpc=ws%3A%2F%2F127.0.0.1%3A9944#/explorer.

docker/rococo-node.dockerfile Outdated Show resolved Hide resolved
@demisx demisx force-pushed the 372-better-docker-files branch 2 times, most recently from fbba320 to b41e9fe Compare September 13, 2022 15:24
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the cli params mostly

docker/rococo-node.dockerfile Outdated Show resolved Hide resolved
docker/rococo-node.dockerfile Outdated Show resolved Hide resolved
docker/rococo-node.dockerfile Outdated Show resolved Hide resolved
docker/rococo-node.dockerfile Outdated Show resolved Hide resolved
docker/rococo-node.dockerfile Outdated Show resolved Hide resolved
docker/rococo-node.dockerfile Outdated Show resolved Hide resolved
@demisx demisx force-pushed the 372-better-docker-files branch 4 times, most recently from 2deee0c to 2ee953a Compare September 13, 2022 20:26
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #417 (d2ef1b9) into main (389a8b4) will decrease coverage by 0.21%.
The diff coverage is n/a.

❗ Current head d2ef1b9 differs from pull request most recent head 5782e71. Consider uploading reports for the commit 5782e71 to get more accurate results

@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
- Coverage   87.34%   87.13%   -0.22%     
==========================================
  Files          26       26              
  Lines        2189     2145      -44     
==========================================
- Hits         1912     1869      -43     
+ Misses        277      276       -1     
Impacted Files Coverage Δ
pallets/msa/src/lib.rs 81.15% <0.00%> (-0.33%) ⬇️
pallets/msa/src/tests.rs 99.72% <0.00%> (-0.02%) ⬇️
pallets/msa/src/types.rs 75.00% <0.00%> (ø)
common/primitives/src/msa.rs 88.88% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@demisx demisx force-pushed the 372-better-docker-files branch 3 times, most recently from 64d2748 to 2a5b694 Compare September 14, 2022 00:11
@demisx demisx requested a review from wilwade September 14, 2022 00:12
@demisx demisx changed the title add Rococo node docker image add parachain node docker image for Rococo and Mainnet Sep 14, 2022
if: matrix.target == 'build-node'
id: docker_build_frequency
run: ./scripts/generate_specs.sh 2000 rococo-2000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed for instant sealing

docker/instant-seal-node.dockerfile Show resolved Hide resolved
docker/parachain-node.dockerfile Show resolved Hide resolved
docker/parachain-node.dockerfile Show resolved Hide resolved
docker/collator-node-local.dockerfile Show resolved Hide resolved
@@ -2,12 +2,14 @@ on:
push:
branches:
- main
# XXX Remove before merging to main
- 372-better-docker-files
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed before merging PR.

@demisx demisx requested a review from wilwade September 14, 2022 18:36
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚂

@demisx demisx closed this Sep 14, 2022
auto-merge was automatically disabled September 14, 2022 22:30

Pull request was closed

@demisx demisx deleted the 372-better-docker-files branch September 14, 2022 22:30
@demisx demisx reopened this Sep 14, 2022
@demisx demisx enabled auto-merge (squash) September 14, 2022 22:41
@demisx demisx merged commit a39b5b4 into main Sep 15, 2022
@demisx demisx linked an issue Sep 15, 2022 that may be closed by this pull request
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better Docker Files
2 participants