chore(upgrade): v1.8.0 to v1.9.0 #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.8.0-to-v1.9.0-issue-1922
branch
2 times, most recently
from
e9f33c4
to
ba953e5
Compare
enddynayn
changed the title
enddynayn
requested review from
aramikm,
saraswatpuneet,
JoeCap08055 and
claireolmstead
and removed request for
wilwade
saraswatpuneet
approved these changes
Jul 26, 2024
github-actions
bot
added
metadata-changed
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.8.0-to-v1.9.0-issue-1922
branch
from
e8ac927
to
21a07b5
Compare
aramikm
approved these changes
Jul 26, 2024
| @@ -668,7 +668,7 @@ fn migration_to_v2_should_work_as_expected() { | |||
|
|
|||
| let old_count = v2::old::Messages::<Test>::iter().count(); | |||
| let new_count = MessagesV2::<Test>::iter().count(); | |||
| let current_version = MessagesPallet::current_storage_version(); | |||
| let current_version = MessagesPallet::in_code_storage_version(); | |||
There was a problem hiding this comment.
We need to ensure these are exactly the same values. If not it would brick the chain.
There was a problem hiding this comment.
Thanks for pointing this out. I forgot to include it in the notable changes section of the PR. It appears to be a rename, and I’ll make sure to add it to the notable changes.
github-actions
bot
added
the
metadata-changed
JoeCap08055
approved these changes
Jul 26, 2024
You are right. I have created a ticket so we can allocate time to investigate where we can move the on_initialize functions to poll. |
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.8.0-to-v1.9.0-issue-1922
branch
from
2f9f0e2
to
8d2f7a5
Compare
github-actions
bot
removed
the
metadata-changed
- Upgrade Polkadot-sdk to v.1.9.0. - Update weights to reflect the new version. Notable Changes: - [System Callabacks](paritytech/polkadot-sdk#1781) - [Remove of pallet pallet::getter](paritytech/polkadot-sdk#3456) - [Add storage_proof_size host function](paritytech/polkadot-sdk#3002) - [Rename of storage version function](https://github.com/paritytech/polkadot-sdk/pull/1554/files#diff-01dc4f43df9baa537f30c6b369525715d596a3068944f38458e9f160d5412d58R306) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.9.0)
enddynayn
force-pushed
the
chore/upgrade-polkadot-v1.8.0-to-v1.9.0-issue-1922
branch
from
8d2f7a5
to
23a0e9f
Compare
github-actions
bot
added
the
metadata-changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable Changes:
For more details, please refer to:
Release Notes