Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e tests: Rrmove extra schema creation #2229

Open
1 task done
aramikm opened this issue Nov 21, 2024 · 2 comments
Open
1 task done

e2e tests: Rrmove extra schema creation #2229

aramikm opened this issue Nov 21, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@aramikm
Copy link
Collaborator

aramikm commented Nov 21, 2024

Feature Description

Details

Currently we are creating schema for every e2e test that needs it. After seeding all DSNP schemas in all of our blockchain images, we don't need to create those schemas unless it is a schema related test.

Searched for Related Issues

  • I have done a search for related issues and either found none, or noted them
@aramikm aramikm added the enhancement New feature or request label Nov 21, 2024
@wilwade
Copy link
Collaborator

wilwade commented Nov 25, 2024

@aramikm Most are using getOrCreate functions from

export async function getOrCreateGraphChangeSchema(source: KeyringPair): Promise<u16> {
right?

I think the only one creating them is one that is testing the creation.

@aramikm
Copy link
Collaborator Author

aramikm commented Nov 27, 2024

We have a lot of ExtrinsicHelper.getOrCreateSchemaV3 usage with different schema names such as test.grantDelegation and ... for different pallets such as stateful pallet or other ones. These could get replaced with a well known schema such as the mentioned method and it would get rid of a lot of duplicated code and schema creation to tests other things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants