Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway_announcement.sh depended on removed dhcpd #126

Closed
AiyionPrime opened this issue Feb 5, 2021 · 7 comments
Closed

gateway_announcement.sh depended on removed dhcpd #126

AiyionPrime opened this issue Feb 5, 2021 · 7 comments
Assignees
Labels

Comments

@AiyionPrime
Copy link
Member

dhcpd was the service file of the isc server, which was removed before kea was rolled out.

The new kea role should have added its own service, which either is just called differently or has not been roled out on sn09 and sn07 for some reason.

This became only clear, after sn09 was deployed tonight, as on sn07 the crontab has been altered in joyful expectation of #124.

This is linked to #113.

@AiyionPrime
Copy link
Member Author

I just looked for references, where it works,
SN01 is not a good example:

Feb 05 05:16:01 sn01 systemd[1]: Starting Kea DHCP Server for IPv4 (kea-dhcp4.conf)...
Feb 05 05:16:01 sn01 systemd[1]: Started Kea DHCP Server for IPv4 (kea-dhcp4.conf).
Feb 05 05:16:01 sn01 kea-dhcp4[26249]: 2021-02-05 05:16:01.328 INFO  [kea-dhcp4.dhcp4/26249.140380574933760] DHCP4_STAR
Feb 05 05:16:01 sn01 kea-dhcp4[26249]: kea-dhcp4 already running? Daemon::createPIDFile: PID: 12005 exists, PID file: /
Feb 05 05:16:01 sn01 kea-dhcp4[26249]: 2021-02-05 05:16:01.332 FATAL [kea-dhcp4.dhcp4/26249.140380574933760] DHCP4_ALRE
Feb 05 05:16:01 sn01 systemd[1]: dhcpd.service: Main process exited, code=exited, status=1/FAILURE
Feb 05 05:16:01 sn01 systemd[1]: dhcpd.service: Failed with result 'exit-code'.

@AiyionPrime
Copy link
Member Author

On sn08 and sn10 the ISC server is still running.

@AiyionPrime AiyionPrime self-assigned this Feb 5, 2021
@AiyionPrime
Copy link
Member Author

AiyionPrime commented Feb 5, 2021

The new kea dhcp role indeed does setup a service which is called differently than dhcpd as of f918f18.

I hotfixed this on sn07 and sn09 but the next roleout of master of us will break things again.
(lemoer codefetch please see this)

This is rather urgent, please reconsider the service name, or give good reason why to keep calling it differently than dhcpd.

It's nice that on of our scripts depended on this, I have no clue what else expects the dhcpd service to be called dhcpd.

@AiyionPrime
Copy link
Member Author

I just added the hotfix to master; in case you decide on changing the service name back to dhcpd the commit to revert is 6c58512

@AiyionPrime AiyionPrime added question and removed bug labels Feb 5, 2021
@AiyionPrime
Copy link
Member Author

Feel free to close once you decided on how to name the service, @1977er :)

@AiyionPrime AiyionPrime changed the title gateway_announcement.sh depends on removed dhcpd gateway_announcement.sh depended on removed dhcpd Feb 5, 2021
@1977er
Copy link
Member

1977er commented Feb 5, 2021

Sorry for the trouble. I wasn't aware of that dep in gateway_announcement. I want to go with the name chosen by Debian. I shouldn't have pushed this to master without a PR.

@1977er 1977er closed this as completed Feb 5, 2021
@AiyionPrime
Copy link
Member Author

No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants