-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wgkex client: Add feature to get gateway from wgkex #142
Comments
While I understand the idea to receive the gateway to connect from the server, instead of having a hardcoded list of gateways baked into the firmware, I don't quite get what this has to do with the wireguard key exchange? This is what the abbreviation "wgkex" means, right? Maybe it would make sense to find a better name (e.g. configbroker) which better resembles the purpose of this server side component? Receiving the Freifunk gateway to connect to doesn't have anything to do with exchanging wireguard keys. |
I see no problem with the name, the software just has the ability to do both. Exchange keys and reply back with a server which received your request. |
@DasSkelett already started on the server site of things. This can also be an optional feature. And will be published under /api/v2 probably. |
Well to me it sounds like adding the feature to serve DNS requests to a HTTP server. Adding some completely unrelated feature to some server side component, just because it is already there. As I tried to explain above - gateway load balancing doesn´t have anything to do with exchanging wireguard keys. |
Wgkex was never meant to only be a keyexchange it was always intended to be a broker for clients that's why the components are already named like that. The reason it does only keyexchanges as of now was simply lack of time ;). |
This is a joke right - the abbreviation wgkex is for wireguard key exchange. That is why I was asking whether we shouldn´t change the name, if it does become a more generic service? |
See this draft from the very beginning of the project freifunkMUC/wgkex#29 |
Maybe the name was a bad choice from the early beginning? |
It's main job is still the wireguard keyexchange the only difference is in the future that it will be smart and only programs keys to Gateways with enough resources and tells the Client about that decision. The name was decided with multiple people back in the time and in my opinion it's pretty much still accurate. |
This will help to spread all nodes over all possible gateways as wgkex can then send the gateway with the least nodes to the node requesting a gateway.
This needs code on the wgkex side as well:
freifunkMUC/wgkex#39
The text was updated successfully, but these errors were encountered: