Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyright info to hoodselector map screenshot #1821

Closed
ghost opened this issue Sep 17, 2019 · 1 comment
Closed

Add copyright info to hoodselector map screenshot #1821

ghost opened this issue Sep 17, 2019 · 1 comment
Labels
0. type: bug This is a bug 3. topic: docs Topic: Documentation

Comments

@ghost
Copy link

ghost commented Sep 17, 2019

The docs of the hoodselector contain a screenshot of OpenStreetMap (i guess). As by https://www.openstreetmap.org/copyright the map material should be credited somehow.

Could someone add a copyright info to the screenshot? Maybe @2tata ?

https://github.com/freifunk-gluon/gluon/blob/master/docs/package/gluon-hoodselector.rst
https://gluon.readthedocs.io/en/latest/package/gluon-hoodselector.html

At least it would be fair, wouldn't it?

@mweinelt mweinelt added 0. type: bug This is a bug 3. topic: docs Topic: Documentation labels Sep 17, 2019
@mweinelt
Copy link
Contributor

mweinelt commented Sep 17, 2019

https://shells.darmstadt.ccc.de/~hexa/gluon/1821/package/gluon-hoodselector.html

Yay? Nay?

commit 798236b3cf443b50f0a847f18032a9728c43f957
Author: Martin Weinelt <[email protected]>
Date:   Tue Sep 17 13:21:16 2019 +0200

    docs: gluon-hoodselector: add openstreetmap copyright
    
    Fixes #1821

diff --git a/docs/package/gluon-hoodselector.rst b/docs/package/gluon-hoodselector.rst
index e1ddc4a6..2600fc0f 100644
--- a/docs/package/gluon-hoodselector.rst
+++ b/docs/package/gluon-hoodselector.rst
@@ -28,7 +28,10 @@ A domain is defined by geostationary fixed shapes by using longitude & latitude
 in combination with the domain configuration system. Below you can see a visual
 example of a regional domain:
 
-.. image:: gluon-hoodselector-domainmap.jpeg
+.. figure:: ./gluon-hoodselector-domainmap.jpeg
+    :alt: Regional domains visualized as shapes defined by latitude & longitude
+
+    © OpenStreetMap contributors
 
 Behaviour
 ------------------
@@ -36,7 +39,7 @@ Behaviour
 The following is an abstract state diagramm which gives an overview
 of the process:
 
-.. image:: gluon-hoodselector.svg
+.. image:: ./gluon-hoodselector.svg
 
 The sequence of this diagram reflects the priority of its running modes.
 Each mode will be explained separately below.
@@ -78,7 +81,7 @@ two coordinates per box are needed to define it (see below for an
 example). The second one uses polygons which can have multiple edges.
 Each domain can hold multiple shapes.
 
-.. image:: gluon-hoodselector-rectangle-example.svg
+.. image:: ./gluon-hoodselector-rectangle-example.svg
 
 site.conf
 ---------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. type: bug This is a bug 3. topic: docs Topic: Documentation
Projects
None yet
Development

No branches or pull requests

1 participant