Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable thumbnail previews in file managers in SecureDrop Workstation VMs #13

Open
redshiftzero opened this issue Sep 6, 2017 · 8 comments

Comments

@redshiftzero
Copy link
Contributor

redshiftzero commented Sep 6, 2017

OG desc:

Nautilus helpfully generates a thumbnail preview of many file types, including images.

However, in our use case, we want to to prevent the parsing of potentially malicious decrypted files in sd-app, so we should disable the thumbnail generation.

Note that to prevent parsing of these files disabling thumbnails is necessary but (possibly) not sufficient, more investigation needed.

With freedomofpress/securedrop-client#2057, a file manager (and thunar, not nautilus) would not be available in sd-app, only in viewer and export VMs, but thumbnail generation should still be disabled.

@redshiftzero redshiftzero added this to the 0.1beta milestone Feb 16, 2018
@adrelanos
Copy link
Contributor

@redshiftzero can you reproduce this inside Qubes-Whonix?

If no, due to QubesOS/qubes-issues#1885 we might be able to close this one as duplicate.

@conorsch
Copy link
Contributor

conorsch commented Nov 1, 2018

Have not tried to reproduce recently, but the original scope of this ticket was in the sd-svs VM, which is not based on the Qubes Whonix Workstation—presumably that's why we saw behavior different from what @adrelanos points out.

Now that we've got the client code coming together, we'll be dropping use of Nautilus altogether in the standard journalist workflow (#179). So the preview issue is now less important than when this issue was first opened. The previews may be relevant for forthcoming workflows such as export, however #84, so leaving open for now. (cc @redshiftzero if you disagree)

@eloquence
Copy link
Member

sd-app (née sd-svs) still ships with Nautilus, but I'm not seeing rich previews at least for JPGs and PDFs. Have we already mitigated this in our config?

@eloquence eloquence changed the title Disable thumbnail previews in Nautilus in sd-svs VM Disable thumbnail previews in Nautilus in sd-app VM Oct 14, 2022
@zenmonkeykstop
Copy link
Contributor

zenmonkeykstop commented May 16, 2024

Need to confirm that tracker-miner has been disabled in sd-app altogether - nautilus may be replaced with thunar based on some issues encountered in the debian-12-based templates with grsec kernels, so we should make sure its equivalent service, if any, is also not processing files to produce thumbnails.

See also https://lwn.net/Articles/947288/

@zenmonkeykstop
Copy link
Contributor

The equivalent service under xfce is tumblerd (which I cannot initially type without leaving out the "e" :/ ) - it's installed as a dependency of thunar but not actually required for it to run. So, we could:

  • just uninstall it in the template
  • add a config file for it under ~/.config that disables all its plugins
  • both, for safety's sake

@zenmonkeykstop zenmonkeykstop changed the title Disable thumbnail previews in Nautilus in sd-app VM Disable thumbnail previews in file managers in SecureDrop Workstation VMs Jun 5, 2024
@zenmonkeykstop
Copy link
Contributor

We should verify that the relevant services are disabled for 1.1.0

@zenmonkeykstop zenmonkeykstop removed this from the 1.1.0 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Cycle Backlog
Development

No branches or pull requests

6 participants