Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pipes dependency (deprecation due in python 3.13) #373

Closed
deeplow opened this issue Mar 22, 2023 · 2 comments
Closed

Replace pipes dependency (deprecation due in python 3.13) #373

deeplow opened this issue Mar 22, 2023 · 2 comments

Comments

@deeplow
Copy link
Contributor

deeplow commented Mar 22, 2023 •
edited
Loading 

dangerzone/isolation_provider/container.py:6
  /home/user/dangerzone/dangerzone/isolation_provider/container.py:6: DeprecationWarning: 'pipes' is deprecated and slated for removal in Python 3.13
    import pipes

We use it only for logging escaping purposes.
@deeplow deeplow added this to the 0.4.1 milestone Mar 22, 2023
@deeplow
Copy link
Contributor Author

deeplow commented Mar 22, 2023

We can just replace pipes.quote() with shlex.quote() since python literally uses that under the hood.

@apyrgio
Copy link
Contributor

apyrgio commented Mar 23, 2023

Sounds good 👍

@eloquence eloquence removed this from the 0.4.1 milestone Mar 23, 2023
@deeplow deeplow mentioned this issue Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eloquence @apyrgio @deeplow