Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparing Dangerzone releases on bulk document conversion: performance, regression testing #352

Open
deeplow opened this issue Feb 23, 2023 · 4 comments
Assignees
Labels
development Development-focused changes
Milestone

Comments

@deeplow
Copy link
Contributor

deeplow commented Feb 23, 2023

We have a work in progress bulk document this. We should compare what's the difference in results from 0.4.0 to 0.4.1.

Update: We have merged the PR to make this work. We should:

  1. Run the large test set now that we have merged the PR in both supported architectures (ideally in MacOS).
  2. Commit the test results and the report in the large test set repo, as 0.4.2 results.
@deeplow deeplow added this to the 0.4.1 milestone Feb 23, 2023
@deeplow deeplow self-assigned this Feb 28, 2023
@deeplow
Copy link
Contributor Author

deeplow commented Mar 2, 2023

I'm now in the process of running these tests. We'll have to wait for the final results to be sure, but so far it looks like replacement of PDFtk with pdftoppm (#338) massively sped up the conversions.

@sssoleileraaa
Copy link

Just capturing that we have some benchmarking results from 0.4.1 testing: https://docs.google.com/spreadsheets/d/1OpKvZxWY2tn9CK2GSaJaqAZarxWDt-AMkB5X9l13ZBM/edit#gid=0

@apyrgio
Copy link
Contributor

apyrgio commented May 8, 2023

Moved to the 0.5.0 milestone, since the related PR will be merged there.

@apyrgio apyrgio modified the milestones: 0.4.1, 0.5.0 May 8, 2023
@apyrgio apyrgio changed the title Comparing 0.4.0 vs. 0.4.1 on bulk document conversion: performance, regression testing Comparing Dangerzone releases on bulk document conversion: performance, regression testing Aug 23, 2023
@apyrgio apyrgio added the development Development-focused changes label Aug 23, 2023
@deeplow
Copy link
Contributor Author

deeplow commented Oct 16, 2023

I have now started the final 0.5.0 large test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Development-focused changes
Projects
None yet
Development

No branches or pull requests

3 participants