Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: VerifyStaticIp when multiple pools #107

Merged
merged 3 commits into from
Aug 23, 2024
Merged

fix: VerifyStaticIp when multiple pools #107

merged 3 commits into from
Aug 23, 2024

Conversation

andy89923
Copy link
Collaborator

@andy89923 andy89923 commented Aug 23, 2024 •
edited
Loading

Description

  • Fix VerifyStaticIp when multiple pools
  • Refactor related code
  • Add test cases

Others

Note

  • Use gin.Mode() == “test” to skip checking MongoDB to see whether have the same static IP settings

@andy89923 andy89923 marked this pull request as draft August 23, 2024 05:15
@andy89923 andy89923 marked this pull request as ready for review August 23, 2024 05:45
@andy89923 andy89923 added the bug Something isn't working label Aug 23, 2024
@andy89923 andy89923 requested a review from ianchen0119 August 23, 2024 05:47
@ianchen0119 ianchen0119 merged commit 7a8282e into free5gc:main Aug 23, 2024
3 checks passed
@andy89923 andy89923 deleted the fix/verify-static-ip branch September 5, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianchen0119 ianchen0119 ianchen0119 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy89923 @ianchen0119