feat: using DAP without nvim-dap-go #216
Conversation
|
Hey @HeavyPunk and many thanks for your contribution! I think this is great and I actually have a colleague at work who wants to avoid depending on dap-go as well. I'm a little busy at the moment but let me take the time to review properly and then let's definitively allow manual DAP config. 👍 |
|
Great! Also I give you example how this feature used in my config: require("neotest-golang") {
dap_manual_enabled = true,
dap_manual_configuration = {
name = "Debug go tests",
type = "go", -- preconfigured DAP adapter name
request = "launch",
mode = "test",
}
} |
|
Hey @fredrikaverpil ! I fixed a strategy selector to prevent loading dap-go and manual-dap modules before executing a logic. At now all of them are lazy-loaded. |
There was a problem hiding this comment.
Great work @HeavyPunk!
I had some minor comments. I can implement these changes myself and get this merged if you like.
tests/unit/options_spec.lua
Outdated
| @@ -13,6 +13,8 @@ describe("Options are set up", function() | |||
| go_list_args = {}, | |||
| gotestsum_args = { "--format=standard-verbose" }, | |||
| dap_go_opts = {}, | |||
| dap_manual_enabled = false, | |||
| dap_manual_configuration = {}, | |||
There was a problem hiding this comment.
Let's shorten dap_manual_configuration to dap_manual_config.
|
Thank you for your review, @fredrikaverpil ! I implement your suggestions by myself. I will call you here a bit later after fixing of code |
|
Hey @fredrikaverpil ! It's ready for your review 😀 |
|
Many thanks @HeavyPunk, I'll have a look and make any additional touch-ups to e.g. README but then I'll merge it in. Looks great, overall! |
|
Thanks! I will be waiting for merge 🎉 |
Hello! I have a nvim config that contains a many of DAP configurations for some languages, also for golang. I don't want to install additional plugin special for debugging go apps or tests (this breaks a consistency of my config). I setup own DAP configuration for this and wanna use it to debug tests with your plugin.