Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit units #43

Closed
fred-wang opened this issue Jun 7, 2015 · 3 comments
Closed

Use explicit units #43

fred-wang opened this issue Jun 7, 2015 · 3 comments

Comments

@fred-wang
Copy link
Owner

For example linethickness="0" should be linethickness="0px"

@fred-wang fred-wang changed the title Use explicit values Use explicit units Jun 7, 2015
@mazeto
Copy link

mazeto commented Jun 5, 2018

Or linethickness="0.1em" for compatibility with hidpi displays.

@fred-wang
Copy link
Owner Author

cc @distler

All unitless length values are discouraged in MathML 3: "A number without a unit is intepreted as a multiple of the reference value. This form is primarily for backward compatibility and should be avoided, prefering explicit units for clarity. " (https://www.w3.org/TR/MathML3/chapter2.html#fund.units)

However, "0" is likely to be preserved in MathML Core: w3c/mathml#24 ; still I think it is safe to use "0px" everywhere so I'll land a commit for that.

@fred-wang
Copy link
Owner Author

Or linethickness="0.1em" for compatibility with hidpi displays.

Using a nonzero value is incorrect, for example the layout of fraction is different depending on whether linethickness is zero or not: https://mathml-refresh.github.io/mathml-core/#mfrac ; also I think some AT rely on that to present fraction differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants