-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update status of reference documents #2380
Open
AyshaHakeem
wants to merge
9
commits into
frappe:develop
Choose a base branch
from
AyshaHakeem:fix-hrms
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+20
−3
Open
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d27b647
fix: update status of reference documents
AyshaHakeem e2611e7
Merge branch 'develop' into fix-hrms
AyshaHakeem e1c8b9c
Merge branch 'develop' into fix-hrms
AyshaHakeem daaf601
fix: set gratuity paid_amont field
AyshaHakeem dc0ba93
Merge branch 'develop' into fix-hrms
AyshaHakeem cb7339d
Merge branch 'frappe:develop' into fix-hrms
AyshaHakeem f551141
Merge branch 'develop' into fix-hrms
AyshaHakeem 59e509d
fix: effect of fnf statement cancellation on gratuity record
AyshaHakeem 6293b61
Merge branch 'develop' into fix-hrms
AyshaHakeem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set paid amount of gratuity doc and call set_status method so that the responsibility of setting the correct status is handled within gratuity itself
Also doesn't handle cancellation