Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: permission error while creating Supplier Quotation from Portal (backport #37864) #37872

Merged
merged 2 commits into from
Nov 3, 2023
Merged

fix: permission error while creating Supplier Quotation from Portal (backport #37864) #37872

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd8a277
fix: permission error while creating Supplier Quotation from Portal
s-aga-r Nov 2, 2023
0dc43e1
chore: `conflicts`
s-aga-r Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions erpnext/controllers/buying_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import frappe
from frappe import ValidationError, _, msgprint
from frappe.contacts.doctype.address.address import get_address_display
from frappe.contacts.doctype.address.address import render_address
from frappe.utils import cint, cstr, flt, getdate

from erpnext.accounts.doctype.budget.budget import validate_expense_against_budget
Expand Down Expand Up @@ -187,7 +187,9 @@ def set_supplier_address(self):

for address_field, address_display_field in address_dict.items():
if self.get(address_field):
self.set(address_display_field, get_address_display(self.get(address_field)))
self.set(
address_display_field, render_address(self.get(address_field), check_permissions=False)
)

def set_total_in_words(self):
from frappe.utils import money_in_words
Expand Down
Loading