refactor: remove extraneous disabled filters #37732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosue
requested review from
rohitwaghchaure,
s-aga-r,
deepeshgarg007,
anandbaburajan and
ruthra-kumar
as code owners
s-aga-r
approved these changes
Oct 30, 2023
s-aga-r
added
backport version-14-hotfix
This was referenced Oct 30, 2023
s-aga-r
pushed a commit
that referenced
this pull request
Oct 30, 2023
refactor: remove extraneous disabled filters (cherry picked from commit f276fbb) Co-authored-by: Bernd Oliver Sünderhauf <[email protected]>
s-aga-r
added a commit
that referenced
this pull request
Oct 30, 2023
* refactor: remove extraneous disabled filters (cherry picked from commit f276fbb) # Conflicts: # erpnext/accounts/report/profitability_analysis/profitability_analysis.js # erpnext/public/js/controllers/accounts.js * chore: `conflicts` --------- Co-authored-by: Bernd Oliver Sünderhauf <[email protected]> Co-authored-by: s-aga-r <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
disabled = 0filter doesn‘t have to be specified. Disabled docs are always excluded from Link options. The extraneous filters only add to complexity both to the codebase and the UI.