-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added read replica support #2195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
jirevwe
reviewed
Dec 9, 2024
This is fine Co-authored-by: Raymond Tukpe <[email protected]>
This is ok too Co-authored-by: Raymond Tukpe <[email protected]>
Co-authored-by: Raymond Tukpe <[email protected]>
jirevwe
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request adds support for read replicas to improve the scalability and efficiency of database read operations by distributing the load across multiple instances. It introduces a random selection strategy for choosing replicas and makes several key updates across the codebase to integrate this functionality.
The changes are explained below.
1. Config Enhancements
The database configuration has been expanded to include support for read replicas using the following JSON structure:
Additionally, a
read-replicas-dsn
configuration option has been introduced to simplify CLI replica setup and integration:2. Repository Refactoring
Database handling in files like
endpoint.go
,event.go
,event_delivery.go
, anduser.go
has been refactored. Instead of directly using*sqlx.DB
, these repositories now rely on thedatabase.Database
interface. This enables dynamic selection between the primary database and a read replica based on the specific needs of the function being executed.3. Feature Gating
The read replica functionality is gated behind a license check to ensure the feature is only available to licensed users.
4. Random Selection Strategy
A random replica selection strategy has been implemented to evenly distribute read operations across available replicas, balancing the load and improving performance. This approach was chosen over a Round Robin strategy or database-level replica management to maintain simplicity and flexibility in the application layer.
These changes maintain backward compatibility while improving flexibility and performance.