Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support job.attribute_filters with a default #775

Closed
tcompa opened this issue Jan 15, 2025 · 1 comment · Fixed by #776
Closed

Support job.attribute_filters with a default #775

tcompa opened this issue Jan 15, 2025 · 1 comment · Fixed by #776
Labels
flexibility Support more workflow-execution use cases

Comments

@tcompa
Copy link
Collaborator

tcompa commented Jan 15, 2025

          As of this morning call:

Let's make sure we only use job.attribute_filters within the runner, and let's make sure that the two clients make it easy to use dataset.attribute_filters as a default value for job.attribute_filters upon submission.

Originally posted by @tcompa in fractal-analytics-platform/fractal-server#2155 (comment)

@tcompa
Copy link
Collaborator Author

tcompa commented Jan 17, 2025

The idea here is that the submission command should be like

  • default: no job.attribute_filters is set
  • something like --attribute-filters-json-file /some/file.json should populate attribute_filters in the POST request
  • something like --use-dataset-attribute-filters should make a preliminary GET request to read the dataset attribute filters, and then populate attribute_filters in the POST request

@ychiucco ychiucco mentioned this issue Jan 17, 2025
1 task
@ychiucco ychiucco linked a pull request Jan 17, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flexibility Support more workflow-execution use cases
Projects
Development

Successfully merging a pull request may close this issue.

1 participant