Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use verbose query parameter in GET /api/v2/task/collect/{state_id}/ #725

Closed
tcompa opened this issue Oct 30, 2024 · 1 comment · Fixed by #730
Closed

Do not use verbose query parameter in GET /api/v2/task/collect/{state_id}/ #725

tcompa opened this issue Oct 30, 2024 · 1 comment · Fixed by #730
Assignees
@ychiucco

Comments

@tcompa
Copy link
Collaborator

tcompa commented Oct 30, 2024

This is being removed from the backend. Let's check if it was still present here, and drop it.
@tcompa
Copy link
Collaborator Author

tcompa commented Oct 30, 2024

We do have a include_logs argument.
When it is True, we have nothing to do.
When it is False, we should just replace data["log"] with None in the response.

@ychiucco ychiucco mentioned this issue Oct 31, 2024
Merged
1 task
@ychiucco ychiucco linked a pull request Oct 31, 2024 that will close this issue
Remove verbose query parameter #730
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ychiucco ychiucco

Labels
None yet
Projects
Fractal Project Management
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove verbose query parameter fractal-analytics-platform/fractal-client
2 participants
@tcompa @ychiucco