Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field.container() now gets the Form if that's the container. Fixes #416 #429

Merged
merged 3 commits into from
Jul 20, 2018

Conversation

wwahammy
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 28, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@139e289). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #429   +/-   ##
=======================================
  Coverage          ?    96%           
=======================================
  Files             ?    113           
  Lines             ?   2230           
  Branches          ?      0           
=======================================
  Hits              ?   2141           
  Misses            ?     89           
  Partials          ?      0
Impacted Files Coverage Δ
src/shared/Utils.js 100% <100%> (ø)
tests/data/forms/fixes/form.s.js 100% <100%> (ø)
src/shared/Actions.js 96.82% <100%> (ø)
tests/nested.props.js 100% <100%> (ø)
tests/fixes.values.js 100% <100%> (ø)
tests/data/_.fixes.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 139e289...663a4a4. Read the comment docs.

@wwahammy
Copy link
Contributor Author

wwahammy commented Jul 6, 2018

There's a second bug I fixed where the del() call was not calculated the container properly in some cases. The most efficient way to fix it was to reuse this.container().

foxhound87 added a commit that referenced this pull request Jul 20, 2018
@foxhound87 foxhound87 merged commit 663a4a4 into foxhound87:master Jul 20, 2018
foxhound87 added a commit that referenced this pull request Jul 20, 2018
@foxhound87
Copy link
Owner

🎉 This PR is included in version 1.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants