Skip to content

Commit

Permalink
fix outdated CI node version (#9)
Browse files Browse the repository at this point in the history
### Changelog
fix outdated CI node version

### Docs
None

### Description
#7 updated the package manager
which requires a newer node version.

CI on that PR passed
(https://github.com/foxglove/ulog/actions/runs/11918005719/job/33214424897),
even though yarn errors are logged 😕
  • Loading branch information
achim-k authored Nov 19, 2024
1 parent d2b2334 commit c307678
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 8 deletions.
20 changes: 13 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,23 +12,29 @@ jobs:
name: push
runs-on: ubuntu-latest

permissions:
# https://docs.npmjs.com/generating-provenance-statements#publishing-packages-with-provenance-via-github-actions
id-token: write

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4.2.2
with:
lfs: true
- uses: actions/setup-node@v2
- run: corepack enable
- uses: actions/[email protected]
with:
node-version: 16.x
registry-url: https://registry.npmjs.org
node-version: 22.x
cache: yarn

- run: corepack enable
- run: yarn install --frozen-lockfile
- run: yarn install --immutable
- run: yarn run build
- run: yarn run lint:ci
- run: yarn run test

- run: yarn pack
- name: Publish to NPM
if: ${{ startsWith(github.ref, 'refs/tags/v') }}
run: yarn publish --access public
# `yarn npm publish` does not currently support --provenance: https://github.com/yarnpkg/berry/issues/5430
run: npm publish package.tgz --provenance --access public
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
7 changes: 6 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -106,5 +106,10 @@ dist
# MacOS
.DS_Store

# Yarn
# Yarn & packaging
.pnp.*
.yarn
!.yarn/patches
!.yarn/plugins
!.yarn/sdks
*.tgz

0 comments on commit c307678

Please sign in to comment.