Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trait upgrades don't let you upgrade a proficiency chosen in the same dialog. #2632

Closed
JPMeehan opened this issue Nov 20, 2023 · 3 comments
Closed
Labels
duplicate This issue or pull request already exists

Comments

@JPMeehan
Copy link
Contributor

I have a homebrew race who has a feature that grants a tool proficiency, and a separate feature that grants expertise in a tool proficiency of the player's choice. It's structured this way so you can use the expertise on a tool proficiency automatically granted by a class, e.g. thieves' tools.

Unfortunately, the current dialog does not recognize the initial tool proficiency as a valid option for a later tool expertise upgrade.

Data wise, this would probably require tracking dialog choices and feeding them back into the display of each step of the advancement dialog.

@JPMeehan
Copy link
Contributor Author

While feats are not implemented as advances, the choice structure is identical to the Skill Expert feat from Tasha's, which has proficiency and expertise as separate choices that can be combined but are not mandatory to do so.

@arbron arbron added the duplicate This issue or pull request already exists label Nov 20, 2023
@arbron
Copy link
Collaborator

arbron commented Nov 20, 2023

The system does currently support this, but it being prevented by another bug: #2596

@JPMeehan
Copy link
Contributor Author

Ah, feel free to mark as duplicate or otherwise handle as you prefer.

@arbron arbron closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants