Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cheatcodes): disable usage of expectRevert with other expect* cheatcodes #5138

Closed
Evalir opened this issue Jun 12, 2023 · 1 comment
Closed

feat(cheatcodes): disable usage of expectRevert with other expect* cheatcodes #5138

Evalir opened this issue Jun 12, 2023 · 1 comment
Assignees
@Evalir
Labels
A-cheatcodes Area: cheatcodes D-average Difficulty: average

Comments

@Evalir
Copy link
Member

Evalir commented Jun 12, 2023

When something reverts, the whole transaction unwinds and it's like nothing happened. However, expectCalls and expectEmits are still matched. We should not allow this to happen, but rather error if we have both a revert and another expect cheatcode being used together at the same time, for the next call.
@Evalir Evalir added A-cheatcodes Area: cheatcodes D-average Difficulty: average labels Jun 12, 2023
@Evalir Evalir self-assigned this Jun 12, 2023
@gakonst gakonst added this to Foundry Jun 12, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Jun 12, 2023
@Evalir Evalir mentioned this issue Jun 12, 2023
Merged
@Evalir
Copy link
Member Author

Evalir commented Jun 12, 2023 •
edited
Loading

Merged into the expect-changes branch (see #5144).

@Evalir Evalir closed this as completed Jun 12, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evalir Evalir

Labels
A-cheatcodes Area: cheatcodes D-average Difficulty: average
Projects
Foundry
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Evalir