Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: nix flakes #315

Closed
sambacha opened this issue Dec 27, 2021 · 11 comments
Closed

Feature: nix flakes #315

sambacha opened this issue Dec 27, 2021 · 11 comments
Labels
A-releases Area: releases/packaging

Comments

@sambacha
Copy link
Contributor

Nix flakes should be the way environments and releases are managed.

No submodules though. Personally I am using dapp2nix https://github.com/icetan/dapp2nix

πŸ’Š + ❄️ + πŸ¦€ = πŸ§™β€β™‚οΈ

@brockelmore
Copy link
Member

brockelmore commented Dec 27, 2021

I have a strong preference against having this be the primary way releases and environments are managed. Having used dapptools for 2 years prior to foundry, I really was not a fan of nix.

That said, if someone wants to actively manage releases for nix users I would be okay with it but definitely don't want to point new users to it. Others may outright shut down the idea fwiw, as my feelings toward nix were common

@wilsoncusack
Copy link
Contributor

Second what @brockelmore said! My first attraction to Foundry was that it doesn't use Nix :)

@sambacha
Copy link
Contributor Author

I have a strong preference against having this be the primary way releases and environments are managed. Having used dapptools for 2 years prior to foundry, I really was not a fan of nix.

That said, if someone wants to actively manage releases for nix users I would be okay with it but definitely don't want to point new users to it. Others may outright shut down the idea fwiw, as my feelings toward nix were common

I honestly find this very surprising.

I don't have a problem doing that, but as it stands there is not release or git tag system which releases can be based off of.

@sambacha
Copy link
Contributor Author

Second what @brockelmore said! My first attraction to Foundry was that it doesn't use Nix :)

Who hurt you?

@brockelmore
Copy link
Member

brockelmore commented Dec 29, 2021

I honestly find this very surprising.

I don't have a problem doing that, but as it stands there is not release or git tag system which releases can be based off of.

heh I think if we ran a poll in the foundry tg my thoughts would be common. Regardless, you're right on the release side of things. I think we are approaching a point where binary and git releases make sense @gakonst

@odyslam
Copy link
Contributor

odyslam commented Dec 29, 2021

Thanks to rust, brew and apt binaries are relatively easy. We had a GHA workflow and pipeline that we never released. Perhaps it's time to revive that

@gakonst
Copy link
Member

gakonst commented Dec 29, 2021

Yeah I think not distributing with Nix was an explicit goal, this will get much easier once we set up our release flows once the project is a bit more stable.

Can always have your own Nix flakes in another repo @sambacha and we can maybe link to it from the README?

@gakonst gakonst added the T-feature Type: feature label Jan 6, 2022
@sambacha
Copy link
Contributor Author

Yeah I think not distributing with Nix was an explicit goal, this will get much easier once we set up our release flows once the project is a bit more stable.

Can always have your own Nix flakes in another repo @sambacha and we can maybe link to it from the README?

yes - however there needs to be a versioning policy, at least something like v0.1.0-nightly-59589

cargo-edit can handle the versioning for Cargo.toml

@onbjerg onbjerg added the A-releases Area: releases/packaging label Jan 22, 2022
@onbjerg onbjerg moved this to Todo in Foundry Apr 17, 2022
@onbjerg onbjerg added this to Foundry Apr 17, 2022
@onbjerg onbjerg removed the T-feature Type: feature label Apr 18, 2022
@sambacha
Copy link
Contributor Author

We have https://github.com/shazow/foundry.nix as a work around, if you want to close this issue

@lucas-manuel
Copy link

Close-able? @mds1

@mds1
Copy link
Collaborator

mds1 commented May 18, 2023

Closing since there is a workaround

@mds1 mds1 closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-releases Area: releases/packaging
Projects
Archived in project
Development

No branches or pull requests

8 participants