-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: nix flakes #315
Comments
I have a strong preference against having this be the primary way releases and environments are managed. Having used dapptools for 2 years prior to foundry, I really was not a fan of nix. That said, if someone wants to actively manage releases for nix users I would be okay with it but definitely don't want to point new users to it. Others may outright shut down the idea fwiw, as my feelings toward nix were common |
Second what @brockelmore said! My first attraction to Foundry was that it doesn't use Nix :) |
I honestly find this very surprising. I don't have a problem doing that, but as it stands there is not release or git tag system which releases can be based off of. |
Who hurt you? |
heh I think if we ran a poll in the foundry tg my thoughts would be common. Regardless, you're right on the release side of things. I think we are approaching a point where binary and git releases make sense @gakonst |
Thanks to rust, brew and apt binaries are relatively easy. We had a GHA workflow and pipeline that we never released. Perhaps it's time to revive that |
Yeah I think not distributing with Nix was an explicit goal, this will get much easier once we set up our release flows once the project is a bit more stable. Can always have your own Nix flakes in another repo @sambacha and we can maybe link to it from the README? |
yes - however there needs to be a versioning policy, at least something like cargo-edit can handle the versioning for |
We have https://github.com/shazow/foundry.nix as a work around, if you want to close this issue |
Close-able? @mds1 |
Closing since there is a workaround |
Nix flakes should be the way environments and releases are managed.
No submodules though. Personally I am using dapp2nix https://github.com/icetan/dapp2nix
π + βοΈ + π¦ = π§ββοΈ
The text was updated successfully, but these errors were encountered: