Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error pass in foundry-evm #3027

Closed
mattsse opened this issue Aug 30, 2022 · 0 comments · Fixed by #2967
Closed

error pass in foundry-evm #3027

mattsse opened this issue Aug 30, 2022 · 0 comments · Fixed by #2967
Assignees
@mattsse
Labels
T-debt Type: code debt T-feature Type: feature

Comments

@mattsse
Copy link
Member

mattsse commented Aug 30, 2022

Component

Forge

Describe the feature you would like

Since bluealloy/revm#191 revm's Database trait supports associated errors.

foundry-evm should roll its own error type instead of using eyre::Report

Additional context

No response
@mattsse mattsse added the T-feature Type: feature label Aug 30, 2022
@mattsse mattsse self-assigned this Aug 30, 2022
@mattsse mattsse added the T-debt Type: code debt label Aug 30, 2022
@gakonst gakonst added this to Foundry Aug 30, 2022
@gakonst gakonst moved this to Todo in Foundry Aug 30, 2022
@mattsse mattsse mentioned this issue Aug 30, 2022
Merged
Repository owner moved this from Todo to Done in Foundry Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattsse mattsse

Labels
T-debt Type: code debt T-feature Type: feature
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: revm breaking changes mattsse/foundry
1 participant
@mattsse