Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cast --from-fix only convert small numbers #2830

Closed
2 tasks done
henry-hz opened this issue Aug 18, 2022 · 1 comment · Fixed by gakonst/ethers-rs#1608
Closed
2 tasks done

cast --from-fix only convert small numbers #2830

henry-hz opened this issue Aug 18, 2022 · 1 comment · Fixed by gakonst/ethers-rs#1608
Labels
C-cast Command: cast T-bug Type: bug

Comments

@henry-hz
Copy link

Component

Cast

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (93ee742 2022-08-18T00:03:59.900816449Z)

What command(s) is the bug in?

cast --from-fix 27 10.55

Operating System

No response

Describe the bug

on bigger numbers it overflows

cast --from-fix 27 10.55
@henry-hz henry-hz added the T-bug Type: bug label Aug 18, 2022
@gakonst gakonst added this to Foundry Aug 18, 2022
@gakonst gakonst moved this to Todo in Foundry Aug 18, 2022
@mattsse mattsse mentioned this issue Aug 18, 2022
Merged
3 tasks
@mattsse
Copy link
Member

mattsse commented Aug 18, 2022

thanks for flagging

fixed here gakonst/ethers-rs#1608

@rkrasiuk rkrasiuk added the C-cast Command: cast label Aug 18, 2022
Repository owner moved this from Todo to Done in Foundry Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cast Command: cast T-bug Type: bug
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support formatting large units mattsse/ethers-rs
3 participants
@henry-hz @mattsse @rkrasiuk