Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semver-compatible nightly versions #2212

Closed
onbjerg opened this issue Jul 5, 2022 · 1 comment · Fixed by #9683
Closed

Use semver-compatible nightly versions #2212

onbjerg opened this issue Jul 5, 2022 · 1 comment · Fixed by #9683
Labels
A-releases Area: releases/packaging
Milestone

Comments

@onbjerg
Copy link
Member

onbjerg commented Jul 5, 2022

Once we cut a stable release we should ditch the nightly-<sha> versions and instead use something semver compatible, e.g. x.y.z-nightly.n+<sha>, where:

  • x.y.z is the next version to be released, or just the latest version with a minor patch (e.g. if latest is x.y.z, then we would use x.y.(z+1))
  • -nightly.n is the prerelease label (as per semver spec), which is used to order releases (which is why n would be the nightly number)
  • +<sha> is metadata that semver does not consider for version ordering

For example, this would be the order of a number of releases and their pre-releases (first one is latest)

1.1.0
1.1.0-nightly.2+abcdef
1.1.0-nightly.1+abcdef
1.1.0-nightly.0+abcdef
1.0.0

This is a breaking change so it should only be considered in the new foundryup. Additionally this requires changes to the release workflow

@onbjerg onbjerg added the A-releases Area: releases/packaging label Jul 5, 2022
@onbjerg onbjerg added this to the v1.0.0 milestone Jul 5, 2022
@onbjerg onbjerg added this to Foundry Jul 7, 2022
@onbjerg onbjerg moved this to Todo in Foundry Jul 7, 2022
@sambacha
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-releases Area: releases/packaging
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants