cast sig does not behave as expected on some inputs

[zk-tarts]

Component

Cast

Have you ensured that all of these are up to date?

• Foundry
• Foundryup

What version of Foundry are you on?

nightly-8478c0841b00789c735df68ad111105fa9204f55

What command(s) is the bug in?

cast sig

Operating System

No response

Describe the bug

This should fail but does not

cast sig "foo(uint999)"
0x54511ad7

This should succeed

cast sig "foo(function() external)"
# panic with 'Illegal abi' message

The root of the problem is really over in ethers-rs. The parser does not handle function types in human readable ABI and does not make sure the bytes/int/uint sizes are correct, among other things. ref gakonst/ethers-rs#474

Some more examples

Arrays with unit sizes are techincally valid solidity

In solidity this expands out to uint[60].

foo(uint[1 minutes] memory)

Arrays have a maximum size in solidity

This gets parsed as correct but is not.

cast sig "foo(uint[99999999999999999])"
0xfece5cb9

[zk-tarts]

Should I have opened this issue in https://github.com/gakonst/ethers-rs/ ? It's really more of a problem there than it is a foundry bug.

[onbjerg]

This should succeed
cast sig "foo(function() external)"

I don't think it should? You cannot make these functions external, so they will never have a 4byte signature.

The others make sense to me.

There is another issue: Some Cast commands (cast call for example), we cannot use structs. AbiParser supports it, but it really just expands them into tuples. We should probably allow people to pass tuples (even though it is technically invalid?) to support people calling functions with structs (and functions that return structs)

Ref #670

It's really more of a problem there than it is a foundry bug.

Probably but I think having a tracking issue here also makes sense 🤷‍♂️

[devanoneth]

FYI this is also seems to be an issue with forge script. I cannot seem to pass a struct as the args for the run function (even after specifying my run function signature with -s).

For -s, I've tried:

run(ScriptTypes.Contracts)
run((address, address, address, address))
run(address, address, address, address)

All to no avail. Would appreciate any support on this!

[onbjerg]

@mattsse Assigning you to this since it's the same underlying issue as #2025 and you assigned yourself to that one

[mattsse]

function types are currently not supported by ethabi, there's simply not a type variant for them

tracked here rust-ethereum/ethabi#273

[zk-tarts]

If ethabi doesn't add function types then you could just treat them as bytes24 https://docs.soliditylang.org/en/latest/abi-spec.html#types

[mattsse]

there are essentially two issues:

• encoding/decoding
• signature

which is handled here

https://github.com/rust-ethereum/ethabi/blob/451d029c69a1fce7c4d57cc117e985a31dc53627/ethabi/src/param_type/writer.rs#L25-L52

and would require another variant

[onbjerg]

Should be fixed in #2151, please let me know if it's not!