Option to ignore warnings from dependencies in foundry.toml #69

loocapro · 2024-02-05T17:19:02Z

Related to #1200

src/compile/output/mod.rs

mattsse

nice, this is pretty close.

only have some style nitpicks

src/compile/output/mod.rs

Co-authored-by: Matthias Seitz <[email protected]>

src/artifacts/mod.rs

mattsse

almost there :)

src/compile/output/mod.rs

mattsse

nice, let's add a simple test for this

todo:

add another test similar to this:

compilers/tests/project.rs

Line 1846 in 564eb85

fn can_apply_libraries_with_remappings() {

The lib code should trigger a warning

configure ignored paths and check output diagnostic

src/artifacts/mod.rs

src/compile/output/mod.rs

src/artifacts/mod.rs

src/compile/output/mod.rs

tests/project.rs

src/compile/output/mod.rs

mattsse

lgtm

first iteration

9b0ff51

mattsse requested changes Feb 7, 2024

View reviewed changes

src/compile/output/mod.rs Outdated Show resolved Hide resolved

loocapro added 2 commits February 7, 2024 14:54

&[PathBuf] and ignoring warnings from source location

9996730

handling artifacts and output diagnostics

e71a014

loocapro requested a review from mattsse February 7, 2024 14:06

loocapro added 4 commits February 8, 2024 12:30

added some test

61b3e54

improved readability

81f409a

redundant comment

079d506

fix: println

d271ad1

mattsse requested changes Feb 8, 2024

View reviewed changes

loocapro and others added 3 commits February 8, 2024 15:50

Update src/compile/output/mod.rs

1110c08

Co-authored-by: Matthias Seitz <[email protected]>

review: contains to starts_with

c1766c9

review

da4b124

DaniPopes reviewed Feb 8, 2024

View reviewed changes

src/artifacts/mod.rs Outdated Show resolved Hide resolved

review: ErrorFilter helper and path::new instead of pathBuf::from

5102181

loocapro requested review from DaniPopes and mattsse February 8, 2024 15:35

loocapro added 2 commits February 8, 2024 16:52

review: error filter to impl Into ErrorFilter

0f66052

fix: removed redundant errorFilter from

3c9e071

mattsse requested changes Feb 8, 2024

View reviewed changes

src/compile/output/mod.rs Outdated Show resolved Hide resolved

src/compile/output/mod.rs Outdated Show resolved Hide resolved

review: from [u64] and map_or instead of match option

9c7fb55

loocapro marked this pull request as ready for review February 8, 2024 16:17

loocapro requested a review from Evalir as a code owner February 8, 2024 16:17

mattsse requested changes Feb 8, 2024

View reviewed changes

review: project test

b09735a

DaniPopes requested changes Feb 8, 2024

View reviewed changes

review: dani pope review

7950b4f

loocapro requested review from DaniPopes and mattsse February 8, 2024 20:08

DaniPopes approved these changes Feb 8, 2024

View reviewed changes

src/compile/output/mod.rs Show resolved Hide resolved

loocapro and others added 2 commits February 8, 2024 21:13

review: error filter: pub(crate) to pub

52f1bff

chore: add docs

b2c7b8a

mattsse approved these changes Feb 9, 2024

View reviewed changes

chore(clippy): make clippy happy

b8b5603

mattsse merged commit c42032f into foundry-rs:main Feb 9, 2024
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Option to ignore warnings from dependencies in foundry.toml #69

Option to ignore warnings from dependencies in foundry.toml #69

loocapro commented Feb 5, 2024

mattsse left a comment

mattsse left a comment

mattsse left a comment

mattsse left a comment

Option to ignore warnings from dependencies in foundry.toml #69

Option to ignore warnings from dependencies in foundry.toml #69

Conversation

loocapro commented Feb 5, 2024

mattsse left a comment

Choose a reason for hiding this comment

mattsse left a comment

Choose a reason for hiding this comment

mattsse left a comment

Choose a reason for hiding this comment

mattsse left a comment

Choose a reason for hiding this comment