Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

Cut a release? #64

Open
felixonmars opened this issue Aug 6, 2018 · 16 comments
Open

Cut a release? #64

felixonmars opened this issue Aug 6, 2018 · 16 comments

Comments

@felixonmars
Copy link
Member

It would be nice to have a versioned release which an initial PyPI upload and distribution packaging could start with.

@felixonmars
Copy link
Member Author

I understand that development is still ongoing and could change very often - but releases can really help start all the packaging bits. If you have trouble with PyPI I can help with all the uploading & updating etc given there are git tags.

The project status field in setup.py could always be used to indicate that it's still in early stage, just in case you have concern in releasing unstable things.

I would like to kick start the packaging bits in this year's GSoC, and this is one of the bottom-level dependencies of susi_linux tree.

@mariobehling
Copy link
Member

Please go ahead with packaging. Would be great!

@hongquan
Copy link
Member

hongquan commented Apr 3, 2019

Honestly, I'm not consent about the design of this piece of software (susi_api_wrapper). I think it is better to reconstruct it before doing packaging.

I'm sorry that I don't have time to do it yet.

@cseas
Copy link
Member

cseas commented May 6, 2019

Can I work on creating a PyPi package for susi_python?

@norbusan
Copy link
Member

norbusan commented May 7, 2019

@hongquan I agree with you that the design/layout is not optimal, in particular because the current repository combines in principle api wrappers for multiple languages.

I would suggest the following;

  • rename the repository from susi_api_wrapper to susi_python
  • move the files from susi_api_wrapper/python_wrapper one level up, so directly into the susi_python repository
  • if need arrives, create new repos for different languages, like susi_mono etc ..
    WDYT?

@cseas What do you think is needed there? A simple

cd susi_api_wrapper.git/python_wrapper
python3 setup.py bdist_wheel

already produces .whl packages. What else are you planning to do?

@hongquan
Copy link
Member

hongquan commented May 7, 2019

@norbusan Agree!

@norbusan
Copy link
Member

norbusan commented May 7, 2019

@norbusan Agree!

Can you create a susi_python repo on github? Then I will move the current files over to preserve the history, and restructure it.

@cseas
Copy link
Member

cseas commented May 7, 2019

@norbusan I wasn't aware of the wheel generation. The README doesn't mention any wheel generation so I thought we just download the repository and run the program inside it by importing susi_python.

I was thinking of releasing a PyPi package for this so the module can be install with pip install susi_python from any terminal. That would make it easier for people to start using and experimenting with it.

@norbusan
Copy link
Member

norbusan commented May 7, 2019

@cseas Yes, that is for sure the idea. I haven't seen any releases so we could very well create a 0.0.1 release, make a whl package, and upload it to the fossasia pip repository.

@norbusan
Copy link
Member

norbusan commented May 7, 2019

@hongquan we could also physically rename the repository, but this is a bit brutal ... and would need adaption of the current raspi image generation (not mine, but the one that generates the current images by @Orbiter)

@cseas
Copy link
Member

cseas commented May 7, 2019

@norbusan That sounds good. Should I look into creating the PyPi package and see if it works well?

@norbusan
Copy link
Member

norbusan commented May 7, 2019

@cseas that is for sure a good idea. Things that need to be checked is whether e.g the RPi image with the normal susi_python removed from SUSI.AI folder, but installed via pip, then the susi_linux app still is working.

@cseas
Copy link
Member

cseas commented May 7, 2019

@norbusan Okay, I'll check it out.

@hongquan
Copy link
Member

hongquan commented May 9, 2019

@norbusan Added the repo susi_python.

@norbusan
Copy link
Member

norbusan commented May 9, 2019

@hongquan I have moved the files with history, and added also Debian packaging. We should probably remove this repository or archive it?

@hongquan
Copy link
Member

@norbusan Archive it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants