Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Location and Map Feature by Switching to OSM and Mapbox #5810

Closed
6 tasks
mariobehling opened this issue Nov 28, 2020 · 6 comments · Fixed by #6026
Closed
6 tasks

Enhance Location and Map Feature by Switching to OSM and Mapbox #5810

mariobehling opened this issue Nov 28, 2020 · 6 comments · Fixed by #6026

Comments

@mariobehling
Copy link
Member

mariobehling commented Nov 28, 2020

Maps are shown using Google Maps currently. As we are trying to get away from Google as a proprietary map tool that collects data of our users we need OpenStreetMap and Mapbox as alternatives. Please implement these services and switch to OpenStreetMaps or MapBox depending on the key provided at runtime.

The following flow is implemented and should work after the map has been changed:
A) For the Organizer and Attendees

  1. User add an address
  2. User can preview the map location and adjust it if if necessary
  3. User saves the changes
  4. Map and address is displayed on the public event page + Map and address is displayed on search pages

B) For Admins

  1. Admin adds a key of OSM and Mapbox into the settings page of the admin area
  2. Saves the details
  3. System uses map solution as provided by admin

Please see the following link for relevant documentation: https://miguelcobain.github.io/ember-leaflet/docs/adding-layers
The outlined solution supports both OSM and MapBox. MapBox WebGL is cheaper than layers approach, but OSM is free. So, the better option is to go for leaflet first and add MapBox WebGL as an additional more powerful solution.

Therefore please implement maps and locations as follows:

As part of this issue

  • please take out the Google map code from the project and ensure there are no console errors.
  • Where necessary open issues and make changes on the open event server.

Screenshot from 2020-11-28 12-29-42

@iamareebjamal
Copy link
Member

More info: #591 and #3564

@iamareebjamal
Copy link
Member

For now, we will implement switching according to environment variables in frontend because it is easier to implement than to do in settings and this is how it is currently done for Google Maps. Also, it is needed at build time of the frontend app to inject in config. Later, we can make it switchable through server by exploring a solution

@maze-runnar
Copy link
Contributor

we will implement switching according to environment variables in frontend

I am not understanding it.

@iamareebjamal
Copy link
Member

First, just implement OSM

@maze-runnar
Copy link
Contributor

ok

@mariobehling
Copy link
Member Author

Google maps is still there. Compare https://eventyay.com/e/fa96ae2c

Therefore re-opening it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants