No Squashing any more :)

[niccokunzmann]

Hi, I just saw something:

@fossasia/gci16-maintainers @jig08 I think, they do not need to squash after all.

[niccokunzmann]

Just creating this issue to inform you.

[niccokunzmann]

Please close if you feel infomed.

[niccokunzmann]

Also, I recognized a button - I do not know who can see it:

Maybe that is the way to go for new people.

[codethejason]

I personally know the option is there, but I think the point of having the PR people squashing their commits is for practice and Git knowledge.

[abishekvashok]

I too knew about squashing and merging commits cause i had write access when the competition has started, I also recommended this to a lot of mentors but theu failed to know of it, this way we could help new members and help them out. While after we could offer them tutorials they could either look or not look at them let it be their choice. They would learn it in the coarse of time. @niccokunzmann i am not seeing that button. I am not having write access. This is the way to go for new people surely.

[jigyasa-grover]

I personally know the option is there, but I think the point of having the PR people squashing their commits is for practice and Git knowledge.

++

[animeshsinghweb]

That's great, but it can sometimes be overwhelming for students to completely understand rebasing in quick span of time, and hence if there is no merge conflict and if students need help squashing, this can be a great option @niccokunzmann :)

[m1guelpf]

@niccokunzmann I shared that a few days ago, but mentors told me that squashing was a great practice

[m1guelpf]

@niccokunzmann Maybe we should add this to mantainers.md, as some emntors are merging unsquashed PRs, and this may be the solution to that.

[jigyasa-grover]

@m1guelpf Update mantainers.md accordingly.
Either the student should squash the commits into one, or the mentors should squash & merge before committing into the main repo.

[m1guelpf]

@jig08 Updated mantainers.md and left there this issue for info. I think this can be closed...