Use NPM for management of client side dependencies #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jQuery UI is not actually used.
The JavaScript client depends on several libraries, which are currently tracked in our repository. This makes keeping up with updates unnecessarily complicated and pollutes the repository. In the past we faced the same problem with PHP dependencies and we solved it using Composer. For JavaScript, Bower and NPM are two most common package managers. Initially, Bower was used for its use of flat dependency tree but in the end NPM prevailed because it is much more common in distribution repositories. This patch modifies the build script to install the dependencies and moves jQuery dependency to the new system. Other dependencies have yet to come. As with Composer, nothing changes for normal user; developers will be forced to update the dependencies on checkout.
In addition to jQuery, we are now also installing the following packages: * malihu custom scrollbar plugin * jQuery Hotkeys * jQuery Mousewheel
The list of assets is now used in both index.php and gruntfile. To make sharing the data easier it was moved to JSON file.
jtojnar
force-pushed
the
npm-deps
branch
2 times, most recently
from
2276a29 to
124a595
Compare
FancyBox was the last of the third party JavaScript libraries. Since the official NPM package only offers the new major version, selfoss was also upgraded to use it. As a bonus, long standing issue with keyboard shortcuts was fixed. Closes: #796
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JavaScript client depends on several libraries, which are currently tracked in our repository. This makes keeping up with updates unnecessarily complicated and pollutes the repository.
In the past we faced the same problem with PHP dependencies and we solved it using Composer. For JavaScript, Bower and NPM are two most common package managers. Initially, Bower was used for its use of flat dependency tree but in the end NPM prevailed because it is much more common in distribution repositories.
As with Composer, nothing changes for normal user; developers will be forced to update the dependencies on checkout.