Folder Support

[koraa]

Hi,
I just tried to import an opml with folders and got the following debug message: "Debug opml import: invalid item $FOLER_NAME ".
I was able to work around this issue by removing the folder tags from the xml.

[ghost]

Hi mappleconfusers,

From which source you took your opml file? Can you post a copy of it?

Thanks

[koraa]

Certanly.
The file was an export of my Liferea feedlist.

This is how the problematic tags are written:

<outline title="Science" text="Science" description="Science" type="folder">

---

Here is the file: https://gist.github.com/mappleconfusers/5221555

[ghost]

Ok thanks. So as there is no folders feature we can use the multi-tags feature in place. So I can propose to add a tag with the name of the folder for each source.

For the moment we only can filter items by one tag, but we can imagine to add the possibility to select more than one so it can be equivalent to folders and subfolders.

Do you think that's a good solution?

[koraa]

I think that would certainly work and that this is probably the most feasible option.

Still you might want to consider these aspects which might cause problems in the future:

• If you implement opml-export the exported opml will not be the same as the imported one
• Tags are not Folders and will therefor be used differently than folders
• Highly nested folders might cause information-flooding (this could be solved by deleting tag-categories)

[ghost]

So in this fix I handle your problem as I said with adding a tag for each parent folders. It's probably only a partial solution but I don't think that's in the philosophy of Selfoss to implents folders. Some erros are still here with your OPML file because Selfoss doesn't support Atom feeds.

I'm waiting for your feedback ;)

[ghost]

I'm sorry I'm not very comfortable with Pull requests but you can find my modifications in my referenced commit ;)

[koraa]

Ok. This seems to work. I still get errors, but I don't think this is caused by your code.
Like I feared the resulting taglist is pretty much a mess. Could you provide an option to use canonical names?

You said you are uncomfortable with pull requests: I think the trick is to create a dedicated branch for every request. Also if you want me to I would be happy to create a pull request for you :)

[ghost]

What do you mean by canonical names?

Thanks, I just don't understand why in my pull request here #153 I can't just have the commit of my branch...

[koraa]

Canonical names like unix paths for instance: newspaper/NY-Times/...

Do you know the Pull Request Docfile? https://help.github.com/articles/using-pull-requests

[koraa]

When I am doing pull requests I normally use the following procedure:

• Create a branch that is up to date with the branch I want to pull request into
• Get my Commits on top of that (rebase/cherry-pick)
• Pull request

I did this here: https://github.com/mappleconfusers/selfoss/tree/pullreq_opml-folders
by using the commands:

git remote add pablor44 "https://github.com/pablor44/selfoss.git" # Add your repo as a remote
git remote update # Fetch all revisions from origin and your fork
git checkout origin/master -b pullreq_opml-folders # Check out the current state of the origin (SSilence / selfoss) into a new branch and switch to that branch
git cherry-pick 7082eb128d306e41caeb15ac09b8590dbc6932db # Cherry-Pick your referenced commit
git push origin pullreq_opml-folders # Upload the new branch

[ghost]

ah ok, I missed the reference to the original repo when I created my branch, so I created it from my polluted master... Thanks I'll can submit clean pull request now :)

[ghost]

Ok thanks! This time my PR is clean with only the commit that I want to submit!

[ghost]

I tried with canonical names too but the result is not really readable because long tag names are not fully displayed...

[SSilence]

Works the current solution for all?

[ghost]

Pull request #170 fix the few errors still returned about Atom feeds.