Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support gcc 13 on windows, better CI and tests, various enhancements #44

Merged
merged 3 commits into from
Oct 18, 2023
Merged

support gcc 13 on windows, better CI and tests, various enhancements #44

merged 3 commits into from
Oct 18, 2023

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Oct 16, 2023 •
edited
Loading

  • expand/automate compatibility testing in weekly workflow
  • consolidate gcc and intel compatibility tables in README.md
  • only test latest toolchain versions on each platform on push/pr
  • set cxx output and CXX env var (previously only env var, and inconsistently)
  • test compiling C/C++ programs
  • update README wording to reflect planned support for standalone Fortran compilers
  • install g++ separately on ubuntu (not included with gcc-13 via APT)
  • support gcc 13 via chocolatey mingw on windows
  • bump default gcc from 11 to 13 (supported on all 3 platforms)

@wpbonelli
refactor: automate intel compat tests, improve cxx support
b5f3953 
* set cxx output and CXX env var (previously only env var, and inconsistently)
* add CI step to test compiling C/C++ programs
* update README wording re: planned support for standalone Fortran compilers
* expand/automate intel compatibility testing
* consolidate gcc and intel compatibility tables in README.md
@wpbonelli wpbonelli marked this pull request as ready for review October 16, 2023 02:56
@wpbonelli wpbonelli requested a review from awvwgk October 16, 2023 03:06
awvwgk
awvwgk requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of testing all available options, but I am not sure if we should really go through the whole job matrix with Intel, since this is incredibly wasteful in CI time.

@wpbonelli
Copy link
Contributor Author

wpbonelli commented Oct 16, 2023 •
edited
Loading

Maybe we can test a subset on PR (e.g. latest known supported of each toolchain on each platform) and move the scheduled trigger, with comprehensive tests, from nightly to weekly or monthly? #33 would make this easier to express in the test workflow.

Ideally I guess compatibility testing should be a one-time task per runner version, but I have seen runner images shift underfoot before.

@wpbonelli wpbonelli marked this pull request as draft October 16, 2023 12:55
@wpbonelli
support gcc 13 on windows, bump default gcc to 13, only test latest c…
61635a7 
…ompiler versions on each platform on push/pr, move schedule trigger to weekly
@wpbonelli wpbonelli changed the title refactor: automate intel compatibility tests, improve cxx support support gcc 13 on windows, better CI and tests, various enhancements Oct 18, 2023
@wpbonelli wpbonelli marked this pull request as ready for review October 18, 2023 04:02
@wpbonelli wpbonelli requested a review from awvwgk October 18, 2023 04:02
@wpbonelli wpbonelli merged commit a0955bb into fortran-lang:main Oct 18, 2023
20 checks passed
@wpbonelli wpbonelli deleted the develop-various branch October 18, 2023 11:46
@wpbonelli wpbonelli mentioned this pull request Dec 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awvwgk awvwgk awvwgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpbonelli @awvwgk