Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--store option: no properties accepted #613

Closed
rsenden opened this issue Sep 27, 2024 · 0 comments
Closed

--store option: no properties accepted #613

rsenden opened this issue Sep 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@rsenden
Copy link
Contributor

rsenden commented Sep 27, 2024

Current Behavior

The help output for the --store option shows the following:

image

However, when trying to pass any such properties, fcli throws an exception:

image

Expected Behavior

Either [=<propertyNames>] should be removed from the --store option description (to indicate that this option accepts only a variable name, not an optional set of properties), or fcli should properly accept an optional list of properties.

Quite likely, the functionality for specifying property names to be stored is already implemented, and it's just the validation not taking into account the possibility of such optional property names. If so, we could either update the regex, or even just keep the current regex but only pass the part before any = sign to the regex.

Steps To Reproduce

No response

Environment

fcli: 2.7.0 (but likely affects all 2.x versions)

Anything else?

No response

@rsenden rsenden added the bug Something isn't working label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant