Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: AWS Security Hub Integration #559

Merged
merged 4 commits into from
Sep 19, 2024
Merged

feat: AWS Security Hub Integration #559

merged 4 commits into from
Sep 19, 2024

Conversation

rohitbaryha1
Copy link
Collaborator

added configuration for AWS security hub

@rohitbaryha1
feat: AWS Security Hub Integration
0339591 
added configuration for AWS security hub
@rohitbaryha1 rohitbaryha1 requested a review from rsenden June 26, 2024 05:21
@rsenden
Copy link
Contributor

rsenden commented Jun 28, 2024 •
edited
Loading

@rohitbaryha1, can you please update the following?

  • Instead of -r / --report-file parameter, please use -f / --file for consistency with other actions and fcli commands.
  • Consider adding a (PREVIEW) label to action header, and explain in description that future versions may provide direct integration with AWS API.

@rohitbaryha1
feat: updated AWS Security Hub Integration templates
c713999 
Updated the column alias and types based on the initial testing
@rohitbaryha1
review comments incorporated
181fee6 
updated as per review comments
@rohitbaryha1
updated as per AWS ASFF
fff536d
@rsenden rsenden merged commit dc79095 into fortify:develop Sep 19, 2024
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsenden rsenden Awaiting requested review from rsenden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohitbaryha1 @rsenden