Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcli ssc appversion-artifact download: Include externalmetadata.xml in downloaded FPR files #257

Closed
rsenden opened this issue Mar 8, 2023 · 0 comments · Fixed by #258 or #259
Closed

Comments

@rsenden
Copy link
Contributor

rsenden commented Mar 8, 2023

When downloading the current state FPR file through the SSC web UI, the FPR file contains externalmetadata.xml. When downloading the current state FPR file using fcli, the FPR file does not contain externalmetadata.xml. Ideally, the FPR file downloaded by fcli should include externalmetadata.xml for use by client-side tools like Audit WorkBench.

Both the SSC web UI and fcli use the same SSC endpoint for downloading the FPR file, but the SSC web UI adds an undocumented clientVersion request parameter that results in externalmetadata.xml being included in the FPR file. We need to engage with SSC engineering team to get more information on this undocumented parameter, like what values can be passed in this parameter, and whether there are any other side-effects other than externalmetadata.xml being included in the FPR file.

As fcli doesn't follow product versioning scheme, sending the fcli version number to SSC doesn't make much sense and may cause issues, so we'd need to find a way to send a proper product version number. Question is what version number to use, and how this influences FPR generation. For example, should we just use a hardcoded version number, or query SSC for the current version number. The latter would require SSC to provide an endpoint to retrieve the version number, which should be accessible by all users and all/most SSC token types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant