Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch+WiiU: Bypasses configured proxy #72

Open
eku opened this issue May 24, 2021 · 10 comments
Open

Switch+WiiU: Bypasses configured proxy #72

eku opened this issue May 24, 2021 · 10 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@eku
Copy link

eku commented May 24, 2021

Describe the bug
A proxy is configured in the Wi-Fi profile, without which the console cannot access the Internet. However, the App Store establishes a connection directly, which logically fails.

Platform:
Switch + WiiU

To Reproduce
Simply enter a proxy in the WiFi profile and do not allow direct connections to the Internet.

@vgmoose vgmoose added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Feb 27, 2022
@vgmoose
Copy link
Member

vgmoose commented Feb 27, 2022

Presumably other Switch homebrews may also have this issue, and a similar fix should work.

@InternalLoss
Copy link

InternalLoss commented Sep 22, 2022

Presumably other Switch homebrews may also have this issue, and a similar fix should work.

Unsure of what it does differently, but nxdumptool does not have this issue I can confirm

@vgmoose
Copy link
Member

vgmoose commented Nov 14, 2022

Is the issue still present? I wonder if updating underlying libcurl libraries resolved it.

@eku
Copy link
Author

eku commented Nov 14, 2022

It's still an issue.

@vgmoose
Copy link
Member

vgmoose commented Nov 14, 2022

Thanks- just confirming. I also should have mentioned the newer build in my last comment (from the Actions tab): https://github.com/fortheusers/hb-appstore/suites/8429699834/artifacts/373293764. This uses the newer libcurl.

@eku
Copy link
Author

eku commented Oct 4, 2024

It's still an issue both on Switch and WiiU!

@vgmoose
Copy link
Member

vgmoose commented Oct 4, 2024

Ahh, okay. it sounds like we may need to manually, per each platform, load proxy settings and apply them directly using Curl opt flags: https://curl.se/libcurl/c/CURLOPT_PROXY.html

The strange thing is that it seems system proxies should be handled, but maybe this behavior is bugged or doesn't work for some reason in hb-appstore: devkitPro/curl@af8d070

@vgmoose
Copy link
Member

vgmoose commented Oct 4, 2024

For reference:

hb-appstore curl code: https://github.com/fortheusers/libget/blob/d341dd58df4e6d231ec4840f64a12394a480c7ab/src/Utils.cpp#L198-L202

nxdumptool (for comparison): https://github.com/DarkMatterCore/nxdumptool/blob/14acd00559e7266029326c16eab0d2cc687d3176/source/core/http.c#L118

Probably to troubleshoot this, it's worth taking the curl example app, to see if 1. that works with the system proxy, and 2. whether or not manually loading it fixes it: https://github.com/switchbrew/switch-examples/tree/master/network/curl

And then try to remove or add curl flags to hb-appstore code until it behaves like the example.

@eku eku changed the title Switch: Bypasses configured proxy Switch+WiiU: Bypasses configured proxy Oct 4, 2024
@eku
Copy link
Author

eku commented Oct 18, 2024

nxdumptool (for comparison): https://github.com/DarkMatterCore/nxdumptool/blob/14acd00559e7266029326c16eab0d2cc687d3176/source/core/http.c#L118

I don't see any curl option for proxy settings there. Are you sure, nxdumptool works behind a proxy?

@vgmoose
Copy link
Member

vgmoose commented Oct 18, 2024

Attached is a build of the curl_example that I mentioned earlier:
curl_example.nro.zip

It displays an error if it fails to connect. It could be that one of the curl flags that hb-appstore adds on (such as the SSL certificate one) interferes with the proxy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants